Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Mar 5, 2024

No description provided.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@zanderso zanderso requested a review from dkwingsmt March 5, 2024 19:18
@zanderso zanderso merged commit 49bc157 into main Mar 5, 2024
@zanderso zanderso deleted the zanderso-patch-5 branch March 5, 2024 20:02
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 5, 2024
…144639)

flutter/engine@3e8b0de...49bc157

2024-03-05 [email protected] Fix typo in githook message (flutter/engine#51205)
2024-03-05 [email protected] Roll Skia from 453cb0d04584 to 875b356e4d96 (2 revisions) (flutter/engine#51202)
2024-03-05 [email protected] Add device selection to `et run` (flutter/engine#51184)
2024-03-05 [email protected] Roll Skia from de108a9c8b54 to 453cb0d04584 (2 revisions) (flutter/engine#51201)
2024-03-05 [email protected] Adds githooks that reminds to run `gclient sync -D` (flutter/engine#51156)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants