Fix custom FlValue API not being exported #51154
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: configuration change Longer term we should see if we can build some test binary in-repo that would catch this. (Although from my experience with similar tests in other repos, it's kind of hit or miss since it's often just as easy to forget to add the new API to the special export test...) |
|
Yeah, I was wondering the best way to test this. It would be nice if the unit tests exerted this somehow. I guess these are easy to forget to add, but unlikely to be accidentally removed. |
…144522) flutter/engine@024ea68...c52b303 2024-03-04 [email protected] Fix custom FlValue API not being exported (flutter/engine#51154) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Would fail to link when using it in a Flutter app.