This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Scenario App: Adds a run_{count}.{backend}. file prefix to every run (on CI)
#51102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 4, 2024
…o every run (on CI) (flutter/engine#51102)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 4, 2024
…144570) flutter/engine@0d8588b...4001881 2024-03-04 [email protected] Reland: [macOS] Use CVDisplayLink to drive repaint (flutter/engine#51126) 2024-03-04 [email protected] Support gtest-parallel when running Impeller unit tests (flutter/engine#51079) 2024-03-04 [email protected] Scenario App: Adds a `run_{count}.{backend}.` file prefix to every run (on CI) (flutter/engine#51102) 2024-03-04 [email protected] Use Instrumentation.waitForIdleSync() after rotation requests. (flutter/engine#51169) 2024-03-04 [email protected] Roll Skia from 9c7d13c05e77 to f65ecbdfb09c (1 revision) (flutter/engine#51170) 2024-03-04 [email protected] Guard against API 22 (flutter/engine#51167) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a flag,
--prefix-logs-per-run, that defaults totrueon CI envrionments.If present, instead of writing the file
${LOGS_DIR}/logcat.txt, we write${LOGS_DIR}/{prefix}.logcat.txt. I don't really like this solution, but alternatives are using zip files (requires downloading to view) or waiting on generic log improvements.Closes flutter/flutter#144402.