This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Test the SurfaceTextureSurfaceProducer-branch in the Android scenario_app
#51061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note to self:
|
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
dnfield
approved these changes
Feb 28, 2024
…orceSurfaceProducerSurfaceTexture
matanlurey
added
the
autosubmit
|
Golden file changes are available for triage from new commit, Click here to view. |
matanlurey
deleted the
scenario_app-debugForceSurfaceProducerSurfaceTexture
branch
5 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 29, 2024
…oid `scenario_app` (flutter/engine#51061)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 29, 2024
…144355) flutter/engine@10331db...61510db 2024-02-28 [email protected] Roll Skia from 27171d6a9205 to f0a60bfe98e0 (4 revisions) (flutter/engine#51068) 2024-02-28 [email protected] Prefix flutter in flutter_vma.h import (flutter/engine#51065) 2024-02-28 [email protected] [Impeller] Cache entire render target and not just allocations. (flutter/engine#50990) 2024-02-28 [email protected] Test the `SurfaceTextureSurfaceProducer`-branch in the Android `scenario_app` (flutter/engine#51061) 2024-02-28 [email protected] Revert "[skwasm] Clip pictures if they go beyond the bounds of the window. (#50887)" (flutter/engine#51067) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
scenario_appto theSurfaceProducerAPI #50993.SurfaceTextureSurfaceProducerwhere it would crash on release (now tested, yay!)Closes flutter/flutter#143539.
Closes flutter/flutter#143483.
/cc @gaaclarke @chinmaygarde, this PR should (after landed) test/verify #50730.