Add et run command

[johnmccutchan]

The run command builds both the host and target engines and then invokes flutter run so that it runs the app using the custom engine builds.

It is expected that 'et run' be used inside the directory of a flutter application.

Command line flags passed after -- will be forwarded to flutter run.

Some examples:

• et run Build the debug variant and runs the app in that mode.
• et run -- --profile Build the profile variant and runs the app in that mode.
• et run -- --release Build the release variant and runs the app in that mode.

Also:

• Start a local_engine.json builder definition (it is missing a lot)
• Tweak the test fixture.
• Add a new Matcher to litetest.
• Tweaked the build config linter to only care about duplicate build names within the same builder.

[loic-sharma]

Awesome work! 🥳

[johnmccutchan]

I can't land this change because:

android_profile_arm64 is duplicated.
	Found definition in /b/s/w/ir/cache/builder/src/flutter/ci/builders/local_engine.json.
	Previous definition was in /b/s/w/ir/cache/builder/src/flutter/ci/builders/mac_android_aot_engine.json.
android_release_arm64 is duplicated.
	Found definition in /b/s/w/ir/cache/builder/src/flutter/ci/builders/local_engine.json.
	Previous definition was in /b/s/w/ir/cache/builder/src/flutter/ci/builders/mac_android_aot_engine.json.
host_debug is duplicated.
	Found definition in /b/s/w/ir/cache/builder/src/flutter/ci/builders/mac_host_engine.json.
	Previous definition was in /b/s/w/ir/cache/builder/src/flutter/ci/builders/local_engine.json.
host_profile is duplicated.
	Found definition in /b/s/w/ir/cache/builder/src/flutter/ci/builders/mac_host_engine.json.
	Previous definition was in /b/s/w/ir/cache/builder/src/flutter/ci/builders/local_engine.json.
host_release is duplicated.
	Found definition in /b/s/w/ir/cache/builder/src/flutter/ci/builders/mac_host_engine.json.
	Previous definition was in /b/s/w/ir/cache/builder/src/flutter/ci/builders/local_engine.json.

I don't think the lint is useful.

[zanderso]

The LUCI recipes understand a | for specifying that either is okay. For example:

engine/ci/builders/mac_ios_engine.json

Line 6 in 6db71f2

"os=Mac-12|Mac-13",

Hadn't added support for it since it wasn't needed, yet, but parsing that would go here: https://github.com/flutter/engine/blob/main/tools/pkg/engine_build_configs/lib/src/build_config.dart#L805.

Suggested change

	"os=Mac-13",
	"os=Linux"
	"os=Mac-13|Linux",

[johnmccutchan]

Will do this in a follow on CL.

[zanderso]

I think this would look like the following:

1. Parse the -d flag and its value out of the flutter command line
2. Run flutter devices --machine which will spit out some json on stdout.
3. Search for the device given by -d in the json and grab the info out of the targetPlatform or sdk field(s).

If there's no -d flag, there's probably some magic to knowing which device is the default one, but this run command could always just require the flag.

[johnmccutchan]

Thanks for this info, I will do this in a follow on CL.

[auto-submit]

auto label is removed for flutter/engine/51037, due to - The status or check suite Mac mac_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

[auto-submit]

auto label is removed for flutter/engine/51037, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.