Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] moved the kernel size assert to a more appropriate location. #50880

Merged
merged 1 commit into from
Feb 22, 2024
Merged

[Impeller] moved the kernel size assert to a more appropriate location. #50880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions impeller/entity/contents/filters/gaussian_blur_filter_contents.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,11 @@ fml::StatusOr<RenderTarget> MakeBlurSubpass(
linear_sampler_descriptor));
GaussianBlurVertexShader::BindFrameInfo(
pass, host_buffer.EmplaceUniform(frame_info));
KernelPipeline::FragmentShader::KernelSamples kernel_samples =
LerpHackKernelSamples(GenerateBlurInfo(blur_info));
FML_CHECK(kernel_samples.sample_count < kMaxKernelSize);
GaussianBlurFragmentShader::BindKernelSamples(
pass, host_buffer.EmplaceUniform(
LerpHackKernelSamples(GenerateBlurInfo(blur_info))));
pass, host_buffer.EmplaceUniform(kernel_samples));
Copy link
Member Author

@gaaclarke gaaclarke Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: despite the name, it isn't actually emplacing in the C++ sense.

return pass.Draw().ok();
};
if (destination_target.has_value()) {
Expand Down Expand Up @@ -478,7 +480,6 @@ KernelPipeline::FragmentShader::KernelSamples GenerateBlurInfo(
KernelPipeline::FragmentShader::KernelSamples result;
result.sample_count =
((2 * parameters.blur_radius) / parameters.step_size) + 1;
FML_CHECK(result.sample_count < kMaxKernelSize);

// Chop off the last samples if the radius >= 3 where they account for < 1.56%
// of the result.
Expand Down