This repository was archived by the owner on Feb 25, 2025. It is now read-only.
  
  
  - 
                Notifications
    You must be signed in to change notification settings 
- Fork 6k
Make Android Studio be able to run android embedding unit tests out of the box #50840
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | @matanlurey very low priority but if you are interested and want to try it out, that would be helpful as I have somewhat low confidence in the reproducibility of any class of "Android Studio doing what I want" outcome. | 
| Thanks so much! 
 This is not low priority, IMO (was talking to @zanderso @mossmana @johnmccutchan about this) giving our contributors consistent access industry standard tools (like IDEs, debuggers, traces) is critical for our long-term success. | 
              
                    matanlurey
  
              
              approved these changes
              
                  
                    Feb 21, 2024 
                  
              
              
            
            
| Thanks so much! 
 This is not low priority, IMO (was talking to @zanderso @mossmana @johnmccutchan about this) giving our contributors consistent access industry standard tools (like IDEs, debuggers, traces) is critical for our long-term success. | 
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Feb 22, 2024 
    
    
      
  
    
      
    
  
…ests out of the box (flutter/engine#50840)
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Feb 22, 2024 
    
    
      
  
    
      
    
  
…ests out of the box (flutter/engine#50840)
    
  auto-submit bot
      pushed a commit
        to flutter/flutter
      that referenced
      this pull request
    
      Feb 22, 2024 
    
    
      
  
    
      
    
  
…143911) flutter/engine@bf5c003...7eeb697 2024-02-22 [email protected] Add view focus direction detection to flutter web. (flutter/engine#50843) 2024-02-22 [email protected] Add a similar `runIf` guard to `web_engine` as web framework. (flutter/engine#50846) 2024-02-22 [email protected] Add scheduleWarmUpFrame (flutter/engine#50570) 2024-02-22 [email protected] Remove/reduce unused or private methods and add tests to `SkiaGoldClient` (flutter/engine#50844) 2024-02-22 [email protected] Clean up contributing formatting, add a Skia gold callout (flutter/engine#50828) 2024-02-21 [email protected] Make Android Studio be able to run android embedding unit tests out of the box (flutter/engine#50840) 2024-02-21 [email protected] Shift some deps to //flutter/third_party (flutter/engine#50830) 2024-02-21 [email protected] Make the view focus binding report focus transitions across elements. (flutter/engine#50610) 2024-02-21 [email protected] [macOS] Wrap FlutterEngineTest in autoreleasepool (flutter/engine#50832) 2024-02-21 [email protected] Update the vulkan_glfw sample for the latest roll of vulkan-deps (flutter/engine#50839) 2024-02-21 [email protected] Roll Skia from 8fa858855820 to 57490c8d257e (6 revisions) (flutter/engine#50833) 2024-02-21 [email protected] Starts a .ci.yaml parser (flutter/engine#50783) 2024-02-21 [email protected] Roll Dart SDK from f344e2266468 to 0f0f7400c38a (6 revisions) (flutter/engine#50837) 2024-02-21 [email protected] [Windows] Fix top-level message procedure order (flutter/engine#50797) 2024-02-21 [email protected] Tweak verbose log messages in ImageReaderSurfaceProducer (flutter/engine#50831) 2024-02-21 [email protected] Add a throw statement for imgtestAdd non 0 exit codes. (flutter/engine#50829) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      Labels
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This is pretty rough, it largely copies the configuration from the
test_runner/build.gradle.But it lets me click and run unit tests without having to rebuild anything, which is nice:
example

Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.