Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fail engine post-submit on skia-gold comparions. #50826

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Fail engine post-submit on skia-gold comparions. #50826

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7a9467
Fail engine postsubmit on skia-gold.
matanlurey Feb 21, 2024
a685a56
Merge branch 'main' into engine-skia-gold-postsubmit
matanlurey Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions testing/skia_gold_client/lib/skia_gold_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,8 @@ class SkiaGoldClient {
'--work-dir', _tempPath,
'--test-name', cleanTestName(testName),
'--png-file', goldenFile.path,
// Otherwise post submit will not fail.
'--passfail',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work. It does not throw for a non-zero exit code below. It just prints. 🙃

..._getMatchingArguments(testName, screenshotSize, pixelDeltaThreshold, maxDifferentPixelsRate),
];

Expand Down