This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Write adb logcat results and screenshots to FLUTTER_LOGS_DIR if able.
#50722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
reidbaker
reviewed
Feb 16, 2024
| ``` | ||
|
|
||
| The result of `adb logcat` and screenshots taken during the test will be stored | ||
| in a logs directory, which is either `FLUTTER_LOGS_DIR` (on CI) or locally in |
Contributor
There was a problem hiding this comment.
nonblocking nit: instead of (on ci) I think it should be (if set like in ci)
reidbaker
approved these changes
Feb 16, 2024
reidbaker
approved these changes
Feb 16, 2024
| [skia-gold-skia-28]: https://flutter-engine-gold.skia.org/search?left_filter=AndroidAPILevel%3D28%26GraphicsBackend%3Dskia&negative=true&positive=true&right_filter=AndroidAPILevel%3D28%26GraphicsBackend%3Dskia | ||
| [skia-gold-impeller-opengles-28]: https://flutter-engine-gold.skia.org/search?left_filter=AndroidAPILevel%3D28%26GraphicsBackend%3Dimpeller-opengles&negative=true&positive=true&right_filter=AndroidAPILevel%3D28%26GraphicsBackend%3Dimpeller-opengles | ||
| --> | ||
|
|
Contributor
There was a problem hiding this comment.
Did you mean to move this? if so ignore this comment.
Contributor
Author
There was a problem hiding this comment.
Yeah unfortunately markdown tables break with inline comments. Was intentional.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
This was referenced Feb 16, 2024
Closed
Contributor
Author
|
Rebased. @gaaclarke PTAL! |
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 18, 2024
…143673) flutter/engine@8ae2321...67abf6e 2024-02-18 [email protected] Write `adb logcat` results and screenshots to `FLUTTER_LOGS_DIR` if able. (flutter/engine#50722) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
approved these changes
Feb 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#143586.
This should make it easier to understand what is/isn't happening, and will unblock flutter/flutter#143458, and make flutter/flutter#143459 potentially easier to debug.