Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@godofredoc
Copy link
Contributor

Support for test timeouts was added on the engine v2 recipes and this is documenting the new properties in build tests and global tests configurations.

Bug: flutter/flutter#143021

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Support for test timeouts was added on the engine v2 recipes and this is
documenting the new properties in build tests and global tests
configurations.

Bug: flutter/flutter#143021
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 15, 2024
@auto-submit auto-submit bot merged commit 4d87d8e into flutter:main Feb 15, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2024
@godofredoc godofredoc deleted the add_docs branch February 16, 2024 01:11
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Feb 16, 2024
2024-02-15 [email protected] Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700)
2024-02-15 [email protected] Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699)
2024-02-15 [email protected] [Android] Remove the unnecessary parent interface. (flutter/engine#50677)
2024-02-15 [email protected] [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698)
2024-02-15 [email protected] Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696)
2024-02-15 6844906[email protected] [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657)
2024-02-15 [email protected] [Impeller] Updated benchmarks (flutter/engine#50694)
2024-02-15 [email protected] Documentation for test timeouts. (flutter/engine#50687)
2024-02-15 [email protected] Shift some Linux builders from Goma to RBE (flutter/engine#50653)
2024-02-15 [email protected] Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 16, 2024
2024-02-15 [email protected] Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700)
2024-02-15 [email protected] Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699)
2024-02-15 [email protected] [Android] Remove the unnecessary parent interface. (flutter/engine#50677)
2024-02-15 [email protected] [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698)
2024-02-15 [email protected] Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696)
2024-02-15 6844906[email protected] [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657) 2024-02-15 [email protected] [Impeller] Updated benchmarks (flutter/engine#50694)
2024-02-15 [email protected] Documentation for test timeouts. (flutter/engine#50687)
2024-02-15 [email protected] Shift some Linux builders from Goma to RBE (flutter/engine#50653)
2024-02-15 [email protected] Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 16, 2024
…143565)

flutter/engine@b7103bc...dd530f1

2024-02-16 [email protected] Roll Dart SDK from 9bbac4d40725 to 947c8c487e28 (1 revision) (flutter/engine#50709)
2024-02-16 [email protected] Roll Skia from 3cbb5d6a71fe to c89a4cd72308 (2 revisions) (flutter/engine#50708)
2024-02-16 [email protected] [Windows] Improve `FlutterWindow` unit tests (flutter/engine#50676)
2024-02-16 [email protected] [et] Adds a logger (flutter/engine#50693)
2024-02-15 [email protected] Update README.md (flutter/engine#50702)
2024-02-15 [email protected] Roll Skia from 078b316e0563 to 3cbb5d6a71fe (2 revisions) (flutter/engine#50704)
2024-02-15 [email protected] Move the accesibility placeholder to the platform dispatcher. (flutter/engine#50608)
2024-02-15 [email protected] Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700)
2024-02-15 [email protected] Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699)
2024-02-15 [email protected] [Android] Remove the unnecessary parent interface. (flutter/engine#50677)
2024-02-15 [email protected] [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698)
2024-02-15 [email protected] Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696)
2024-02-15 6844906[email protected] [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657)
2024-02-15 [email protected] [Impeller] Updated benchmarks (flutter/engine#50694)
2024-02-15 [email protected] Documentation for test timeouts. (flutter/engine#50687)
2024-02-15 [email protected] Shift some Linux builders from Goma to RBE (flutter/engine#50653)
2024-02-15 [email protected] Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants