Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Feb 13, 2024

Partial work towards flutter/flutter#143351.

I filed flutter/flutter#143374 about the state of the docs, it was hard to figure this out.

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #50583 at sha dd38e03

@matanlurey matanlurey merged commit 215d55f into flutter:main Feb 14, 2024
@matanlurey matanlurey deleted the engine-emulator_api_v28_scenario_app branch February 14, 2024 01:12
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 14, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 14, 2024
…143422)

flutter/engine@c0607a0...215d55f

2024-02-14 [email protected] Run Skia and Impeller OpenGLES on APIv28. (flutter/engine#50583)
2024-02-14 [email protected] Make Android Studio depend on the android_embedding_dependencies (flutter/engine#50612)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants