[Impeller] force render pass construction on all backends to ensure image layout is transitioned/render pass state setup. #50539

jonahwilliams · 2024-02-10T21:39:01Z

We rely on the render pass encoding to transition image textures from undefined to shader read layout. If an empty pass is created with no clear color, we still need to create the pass on the Vulkan backend.

flutter-dashboard · 2024-02-11T20:33:44Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #50539 at sha a15bfdb

jonahwilliams · 2024-02-12T16:59:28Z

testing/run_tests.py

 import tempfile
 import time
 import typing
 import xvfb


The formatter told me to do this.

impeller/aiks/aiks_unittests.cc

gaaclarke · 2024-02-12T17:12:52Z

testing/run_tests.py

 import tempfile
 import time
 import typing
 import xvfb


gaaclarke · 2024-02-12T17:31:43Z

Ahh shoot, I lost my big comment. I hit submit before hitting the "Add comment" button.

gaaclarke · 2024-02-12T17:35:21Z

impeller/entity/entity_pass.cc

+  if (!collapsed_parent_pass && (GetClearColor(clear_color_size).has_value() ||
+                                 renderer.GetContext()->GetBackendType() ==
+                                     Context::BackendType::kVulkan)) {


What my big comment here said was that I'm wary of adding branches in the crossplatform code since I think it can lead to an unclear abstraction and code that's hard to follow. I think we should turn this to a different abstraction pass_context.GetRenderPass(pass_depth, GetClearColor(clear_color_size)). Inside that function it can check to see if the color has value and also call onto the renderpass something like pass_->SetImageLayout() which is only implemented for RenderPassVK. That way there will be no branch, but just SetImageLayout() that does nothing except on vulkan. Maybe we could even use more generic name. PrepareRenderPass?

I understand the concern about branches but adding a virtual method that is only implemented in one backend is roughly equivalent to a branch, no?.

I could definitely make this clearer by pulling the condition out to a helper method though

(If you don't like this one, you're gonna hate the next PR I send you)

I understand the concern about branches but adding a virtual method that is only implemented in one backend is roughly equivalent to a branch, no?.

There is a subtle difference that when you make a virtual method. You are contributing to an interface which collectively defines the abstraction. If you add branching statements there is no single place that defines or enforces the interface.

Imagine we wanted to add a directx backend, if we had the branch we wouldn't know that we need to make a decision about wether we need to setup the renderpass regardless, like we do in vulkan.

Also, when we expand the abstraction, people can read through that interface and understand the system hierarchically. With branches the interface exists but it is implicit and spread around multiple locations.

I don't think exposing ImageLayout is the right way to do that though, that requires tons of Vulkan only internal state to be exposed to entity pass.

Imagine we wanted to add a directx backend,

I mean, we can handle that if/when we do DirectX.

I don't think exposing ImageLayout is the right way to do that though, that requires tons of Vulkan only internal state to be exposed to entity pass.

It won't be tons of state, it will just be a hook like PrepareRenderPass(). You understand how branching on the backend type compromises the abstraction, right?

Would you like me to take a stab at proposing an alternative that expands the interface? If this comes up in a later PR it could potentially serve as a template there too.

I think the abstraction being intentionally leaky (as its private API) is valuable.

If you wanna take a crack at it, have at it, I'm not in a rush :)

…ngine into force_create_render_pass

gaaclarke · 2024-02-12T18:23:41Z

FYI I'm seeing a magenta square (error color) on the metal invocation of the new test. It looks fine in the golden image test.

jonahwilliams · 2024-02-12T18:25:01Z

oh interesting. i wonder if this is actually a problem on Metal too?

jonahwilliams · 2024-02-12T18:25:23Z

What if we just made this unconditional?

gaaclarke · 2024-02-12T18:29:12Z

What if we just made this unconditional?

That fixes the error for me and avoids the discussion about the branching.

flutter-dashboard · 2024-02-12T18:39:44Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #50539 at sha 1cbcbe9

gaaclarke

LGTM, can you file an issue against the golden test runner for the fact that it succeeded here where local testing would fail?

jonahwilliams · 2024-02-12T19:52:36Z

Done: flutter/flutter#143324

jonahwilliams · 2024-02-12T19:55:44Z

Thanks for being thorough as always @gaaclarke 😄

…o ensure image layout is transitioned/render pass state setup. (flutter/engine#50539)

…sions) (#143380) Manual roll Flutter Engine from 1c3ecee77350 to 920874bf2c1a (34 revisions) Manual roll requested by [email protected] Cannot build log URL because revision "920874bf2c1a" is invalid: Luci builds of "Linux Fuchsia FEMU" for 920874bf2c1a9ba2e9b7260b79ede8f1e26ea4f0 was FAILURE 2024-02-13 [email protected] Do not use AChoreographer on 32 bit devices (flutter/engine#50586) 2024-02-13 [email protected] Move libpng to //flutter/third_party/libpng (flutter/engine#50571) 2024-02-13 [email protected] Roll Skia from b150107d536d to aaed347b2dbb (2 revisions) (flutter/engine#50595) 2024-02-13 [email protected] Roll Dart SDK from 8d3a8d85c883 to 105312b80125 (2 revisions) (flutter/engine#50593) 2024-02-13 [email protected] Roll Skia from d503bc9c6e46 to b150107d536d (1 revision) (flutter/engine#50591) 2024-02-13 [email protected] Roll Skia from a1d9b83034ac to d503bc9c6e46 (3 revisions) (flutter/engine#50587) 2024-02-13 [email protected] [Impeller] cleaned up and removed golden test exceptions (flutter/engine#50572) 2024-02-13 [email protected] Roll Skia from 17d00f9241b3 to a1d9b83034ac (2 revisions) (flutter/engine#50582) 2024-02-13 [email protected] Roll Fuchsia Linux SDK from RVHAIKU50ogkiV-Lj... to l6mWjvlO1xJg5ZFKK... (flutter/engine#50579) 2024-02-13 [email protected] Roll Dart SDK from 94f7dec34cef to 8d3a8d85c883 (1 revision) (flutter/engine#50577) 2024-02-13 [email protected] Add Impeller runtime options to Android `scenario_app` (flutter/engine#50487) 2024-02-13 [email protected] Roll Skia from c464143dfaab to 17d00f9241b3 (1 revision) (flutter/engine#50576) 2024-02-13 [email protected] Roll Skia from ecf2f622d0b3 to c464143dfaab (2 revisions) (flutter/engine#50574) 2024-02-12 [email protected] [Impeller] CommandPoolVK recycles command buffers too. (flutter/engine#50468) 2024-02-12 [email protected] Make `dart:ui#Paint` `final` to allow changes/disallow implementing. (flutter/engine#50557) 2024-02-12 [email protected] Replace usage of an integer for GdkModifierType (flutter/engine#50481) 2024-02-12 [email protected] Remove FlKeyEvent.dispose_origin and use GdkEvent type for origin (flutter/engine#50483) 2024-02-12 [email protected] Move Linux impeller_unittests to linux_unopt (flutter/engine#50558) 2024-02-12 [email protected] [Impeller] Don't suppress outdated validation error. (flutter/engine#50568) 2024-02-12 [email protected] [Impeller] Remove references to moved impeller/image from README. (flutter/engine#50513) 2024-02-12 [email protected] Roll Dart SDK from dca13675e65e to 94f7dec34cef (1 revision) (flutter/engine#50567) 2024-02-12 [email protected] Roll Skia from f88eeb658358 to ecf2f622d0b3 (1 revision) (flutter/engine#50566) 2024-02-12 [email protected] Roll Skia from 867c1e8390e2 to f88eeb658358 (5 revisions) (flutter/engine#50564) 2024-02-12 [email protected] Roll vulkan-deps to 014f44e134a1de387791bffacc32ff9d8db71176 (flutter/engine#50515) 2024-02-12 [email protected] Roll Skia from 4081496b7693 to 867c1e8390e2 (20 revisions) (flutter/engine#50562) 2024-02-12 [email protected] [Impeller] force render pass construction on all backends to ensure image layout is transitioned/render pass state setup. (flutter/engine#50539) 2024-02-12 [email protected] [Windows] Make the view own its EGL surface (flutter/engine#50421) 2024-02-12 [email protected] Roll Dart SDK from 5c9e79e66364 to dca13675e65e (1 revision) (flutter/engine#50559) 2024-02-12 [email protected] [fuchsia] Update Inspect library usage (flutter/engine#50467) 2024-02-12 [email protected] Initializes RBE in the build config runner (flutter/engine#50543) 2024-02-12 [email protected] Rename [ViewFocusDirection.backwards] to [ViewFocusDirection.backward] (flutter/engine#50533) 2024-02-12 [email protected] Refactor NDK helpers some more, add methods for SurfaceControl/Transaction, tests (flutter/engine#50540) 2024-02-12 [email protected] [Impeller] deleted the old blur (flutter/engine#50470) 2024-02-12 [email protected] Update codec defines for Skia (flutter/engine#50554) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from RVHAIKU50ogk to l6mWjvlO1xJg If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. ...

This was fixed in #50539

jonahwilliams added 2 commits February 10, 2024 13:13

[Impeller] fix missing layout transition for empty passes.

ed806d2

++

3524b4b

github-actions bot added the e: impeller label Feb 10, 2024

jonahwilliams added 2 commits February 11, 2024 11:09

update test number.

c0c2665

format

a15bfdb

jonahwilliams marked this pull request as ready for review February 11, 2024 20:30

flutter-dashboard bot added the will affect goldens label Feb 11, 2024

jonahwilliams requested a review from gaaclarke February 12, 2024 16:59

jonahwilliams commented Feb 12, 2024

View reviewed changes

gaaclarke reviewed Feb 12, 2024

View reviewed changes

Update aiks_unittests.cc

de6689d

gaaclarke reviewed Feb 12, 2024

View reviewed changes

jonahwilliams added 3 commits February 12, 2024 09:55

move forced creation to helper method.

caad369

Merge branch 'force_create_render_pass' of github.com:jonahwilliams/e…

fd1c9ea

…ngine into force_create_render_pass

++

1cbcbe9

unconditional.

598fc08

gaaclarke approved these changes Feb 12, 2024

View reviewed changes

jonahwilliams changed the title ~~[Impeller] force render pass construction on Vulkan backend to ensure image layout is transitioned.~~ [Impeller] force render pass construction on all backends to ensure image layout is transitioned/render pass state setup. Feb 12, 2024

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2024

auto-submit bot merged commit 09c3166 into flutter:main Feb 12, 2024

jonahwilliams deleted the force_create_render_pass branch February 12, 2024 20:00

engine-flutter-autoroll mentioned this pull request Feb 12, 2024

Roll Flutter Engine from a19077503a0c to 09c3166565aa (1 revision) flutter/flutter#143327

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 12, 2024

09c316656 [Impeller] force render pass construction on all backends t…

77f1420

…o ensure image layout is transitioned/render pass state setup. (flutter/engine#50539)

engine-flutter-autoroll mentioned this pull request Feb 13, 2024

Manual roll Flutter Engine from 1c3ecee77350 to 920874bf2c1a (34 revisions) flutter/flutter#143380

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 13, 2024

09c316656 [Impeller] force render pass construction on all backends t…

63001c3

…o ensure image layout is transitioned/render pass state setup. (flutter/engine#50539)

This was referenced Feb 13, 2024

[Impeller] Play/AiksTest.EmptySaveLayerRendersWithClear/Vulkan has validation warnings flutter/flutter#142080

Closed

[Impeller] remove denylist entry. #50605

Merged

jason-simmons mentioned this pull request Feb 13, 2024

[Impeller] Changes needed to get the OpenGL backend running on desktop Linux flutter/flutter#143387

Closed

auto-submit bot pushed a commit that referenced this pull request Feb 13, 2024

[Impeller] remove denylist entry. (#50605)

0091a49

This was fixed in #50539

This was referenced Mar 10, 2024

[Impeller] Glitch On Dismissible Down and End To Start Direction / Simulator. flutter/flutter#137755

Closed

Disable partial repaint on iOS simulators. flutter/flutter#138125

Closed

[Impeller] force render pass construction on all backends to ensure image layout is transitioned/render pass state setup. #50539

[Impeller] force render pass construction on all backends to ensure image layout is transitioned/render pass state setup. #50539

Uh oh!

Conversation

jonahwilliams commented Feb 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Feb 11, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gaaclarke commented Feb 12, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gaaclarke commented Feb 12, 2024

Uh oh!

jonahwilliams commented Feb 12, 2024

Uh oh!

jonahwilliams commented Feb 12, 2024

Uh oh!

gaaclarke commented Feb 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Feb 12, 2024

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

jonahwilliams commented Feb 12, 2024

Uh oh!

jonahwilliams commented Feb 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jonahwilliams commented Feb 10, 2024 •

edited

Loading

gaaclarke commented Feb 12, 2024 •

edited

Loading