This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[iOS] Ensure FlutterMetalLayer has correct backpressure. #50486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 8, 2024 20:31
jonahwilliams
commented
Feb 9, 2024
| [self removeMetalLayer:layer]; | ||
| } | ||
|
|
||
| - (void)testTimeout { |
There was a problem hiding this comment.
This needs more thought, I haven't actually looked at how to grab the usage flag in the test yet
There was a problem hiding this comment.
The test fails because isInUse=true doesn't prevent layer from returning the surface.
isInUse=false: Compositor is definitely not using the surface. This is useful to reuse surface immediately after a dropped frame.
isInUse=true: Compositor may be using the surface. if there is no surface with isInUse=false, return one with isUnUse=true that was presented longest time ago.
The blocking in this PR is performed when front surface command buffer has not been completed. This is different from compositor using the surface. The test will likely need to call flutterPrepareForPresent: with command buffer and then test if nextSurface blocks while the command buffer waits for completion.
|
@jonahwilliams, I added PR for the test in jonahwilliams#1 |
Get testTimeout to work
|
Thank you! |
jonahwilliams
changed the title
jonahwilliams
added
the
autosubmit
sealesj
pushed a commit
to sealesj/engine
that referenced
this pull request
Feb 15, 2024
See also flutter/flutter#140901 . We were not accounting for GPU backpressure in the FML, this applies the patch from @knopp to track this.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2024
jason-simmons
added a commit
to jason-simmons/flutter
that referenced
this pull request
Feb 16, 2024
2024-02-15 [email protected] Added tool to easily check golden diffs locally. (flutter/engine#50654) 2024-02-15 [email protected] Roll Skia from 4bbf2060b008 to 12d0b7fac4c3 (2 revisions) (flutter/engine#50689) 2024-02-15 [email protected] Provide a matrix inverse shim for GLES 2.0. (flutter/engine#50545) 2024-02-15 [email protected] [iOS] Ensure FlutterMetalLayer has correct backpressure. (flutter/engine#50486) 2024-02-15 [email protected] Roll Skia from 682f0e1e7e77 to 4bbf2060b008 (3 revisions) (flutter/engine#50686) 2024-02-15 [email protected] Pin OSV-Scanner reusable workflow (flutter/engine#50649) 2024-02-15 [email protected] Add support for dart_src GN variable to flutter_frontend_server build (flutter/engine#50685) 2024-02-15 [email protected] fix: consider array size on canvaskit shader data (flutter/engine#49754) 2024-02-15 [email protected] Roll Skia from 1277910beec9 to 682f0e1e7e77 (1 revision) (flutter/engine#50683) 2024-02-15 [email protected] Roll Skia from 85ab600a9519 to 1277910beec9 (2 revisions) (flutter/engine#50682)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 16, 2024
2024-02-15 [email protected] Added tool to easily check golden diffs locally. (flutter/engine#50654) 2024-02-15 [email protected] Roll Skia from 4bbf2060b008 to 12d0b7fac4c3 (2 revisions) (flutter/engine#50689) 2024-02-15 [email protected] Provide a matrix inverse shim for GLES 2.0. (flutter/engine#50545) 2024-02-15 [email protected] [iOS] Ensure FlutterMetalLayer has correct backpressure. (flutter/engine#50486) 2024-02-15 [email protected] Roll Skia from 682f0e1e7e77 to 4bbf2060b008 (3 revisions) (flutter/engine#50686) 2024-02-15 [email protected] Pin OSV-Scanner reusable workflow (flutter/engine#50649) 2024-02-15 [email protected] Add support for dart_src GN variable to flutter_frontend_server build (flutter/engine#50685) 2024-02-15 [email protected] fix: consider array size on canvaskit shader data (flutter/engine#49754) 2024-02-15 [email protected] Roll Skia from 1277910beec9 to 682f0e1e7e77 (1 revision) (flutter/engine#50683) 2024-02-15 [email protected] Roll Skia from 85ab600a9519 to 1277910beec9 (2 revisions) (flutter/engine#50682)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also flutter/flutter#140901 . We were not accounting for GPU backpressure in the FML, this applies the patch from @knopp to track this.