[Impeller] Log non-default graphics backend usages, use IMPORTANT rather than ERROR #50448
Conversation
| constexpr LogSeverity kLogNumSeverities = 4; | ||
| // A log that is not an error, is important enough to display even if ordinary | ||
| // info is hidden. | ||
| constexpr LogSeverity kLogImportant = 3; |
There was a problem hiding this comment.
Will this break users who set a log level on the command line? If so, should we add a note in our release notes?
There was a problem hiding this comment.
It shouldn't - I'm replacing the FATAL level with IMPORTANT - it's not actually possible to ignore FATAL, but I suppose someone who was suppressing ERROR will now get IMPORTANT. I doubt this is happening much if at all though.
There was a problem hiding this comment.
We should really move the iOS/macOS logging from syslog to os_log. That's been on my backlog list for a long time...
I think LOG_ALERT still shows up as an error (OS_LOG_TYPE_ERROR)? When you use IMPORTANT does it still look like:
[ERROR:flutter/shell/platform/darwin/graphics/FlutterDarwinContextMetalImpeller.mm] blah
The |
|
(it's quite possible that Console.app will still show it as some kind of error even though the string won't say ERROR...) |
…ORTANT rather than ERROR (flutter/engine#50448)
…143123) flutter/engine@b1ba9f3...322a461 2024-02-07 [email protected] Roll Skia from eacaa2d3600c to 8332438cbeb9 (6 revisions) (flutter/engine#50451) 2024-02-07 [email protected] [Impeller] Log non-default graphics backend usages, use IMPORTANT rather than ERROR (flutter/engine#50448) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fixes flutter/flutter#142488