This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Optimizations for TLHC frame rate and jank #50033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
suggested changes
Jan 25, 2024
shell/platform/android/io/flutter/embedding/engine/renderer/FlutterRenderer.java
Outdated
Show resolved
Hide resolved
shell/platform/android/io/flutter/embedding/engine/renderer/FlutterRenderer.java
Show resolved
Hide resolved
shell/platform/android/io/flutter/embedding/engine/renderer/FlutterRenderer.java
Show resolved
Hide resolved
shell/platform/android/test/io/flutter/embedding/engine/renderer/FlutterRendererTest.java
Outdated
Show resolved
Hide resolved
shell/platform/android/io/flutter/embedding/engine/renderer/FlutterRenderer.java
Show resolved
Hide resolved
shell/platform/android/io/flutter/embedding/engine/renderer/FlutterRenderer.java
Show resolved
Hide resolved
shell/platform/android/io/flutter/embedding/engine/renderer/FlutterRenderer.java
Show resolved
Hide resolved
Contributor
|
I manually tested this locally on the various examples and integration tests I've been hacking on, looks fine. LGTM. |
- ImageReaderSurfaceProducer no longer drops frames when the producer and the consumers are up to two frames out of sync. - Have the native C++ side of the Android external textures check if a new frame has been pushed and that the texture needs to be updated. This avoids having to schedule a task on the raster thread for each updated texture. - Notify the engine earlier that a frame is needed when updating a TLHC texture.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 25, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 25, 2024
…142264) flutter/engine@4b145d0...44f2627 2024-01-25 [email protected] Add include suggested by clang-tidy (flutter/engine#49898) 2024-01-25 [email protected] Refactor macOS trackpad gesture tracking (flutter/engine#49424) 2024-01-25 [email protected] winding order from tesellator.h to formats.h (flutter/engine#49865) 2024-01-25 [email protected] Roll webp to 1.3.2 (flutter/engine#49883) 2024-01-25 [email protected] Optimizations for TLHC frame rate and jank (flutter/engine#50033) 2024-01-25 [email protected] Roll Skia from 29b545e4356b to 801bb44f2b09 (1 revision) (flutter/engine#50051) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso
added
the
revert
auto-submit bot
added a commit
to flutter/flutter
that referenced
this pull request
Jan 25, 2024
…isions)" (#142274) Reverts #142264 Initiated by: zanderso This change reverts the following previous change: Original Description: flutter/engine@4b145d0...44f2627 2024-01-25 [email protected] Add include suggested by clang-tidy (flutter/engine#49898) 2024-01-25 [email protected] Refactor macOS trackpad gesture tracking (flutter/engine#49424) 2024-01-25 [email protected] winding order from tesellator.h to formats.h (flutter/engine#49865) 2024-01-25 [email protected] Roll webp to 1.3.2 (flutter/engine#49883) 2024-01-25 [email protected] Optimizations for TLHC frame rate and jank (flutter/engine#50033) 2024-01-25 [email protected] Roll Skia from 29b545e4356b to 801bb44f2b09 (1 revision) (flutter/engine#50051) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
This reverts commit 57099ca.
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Jan 25, 2024
Reverts #50033 Initiated by: zanderso This change reverts the following previous change: Original Description: - ImageReaderSurfaceProducer no longer drops frames when the producer and the consumers are up to two frames out of sync. - Have the native C++ side of the Android external textures check if a new frame has been pushed and that the texture needs to be updated. This avoids having to schedule a task on the raster thread for each updated texture. - Notify the engine earlier that a frame is needed when updating a TLHC texture.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 26, 2024
…sions) (#142278) Manual roll requested by [email protected] flutter/engine@4b145d0...9142fc4 2024-01-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Optimizations for TLHC frame rate and jank" (flutter/engine#50062) 2024-01-25 [email protected] [Impeller] Fix advanced blend alpha issue, improve blend goldens. (flutter/engine#50035) 2024-01-25 [email protected] Fix android new engine in group (flutter/engine#49659) 2024-01-25 [email protected] Remove fuchsia from allowed_hosts post-migration (flutter/engine#50013) 2024-01-25 [email protected] Roll Skia from 801bb44f2b09 to cc5124317c18 (1 revision) (flutter/engine#50054) 2024-01-25 [email protected] Fix a typo in ChannelBuffers documentation (flutter/engine#49928) 2024-01-25 [email protected] Add include suggested by clang-tidy (flutter/engine#49898) 2024-01-25 [email protected] Refactor macOS trackpad gesture tracking (flutter/engine#49424) 2024-01-25 [email protected] winding order from tesellator.h to formats.h (flutter/engine#49865) 2024-01-25 [email protected] Roll webp to 1.3.2 (flutter/engine#49883) 2024-01-25 [email protected] Optimizations for TLHC frame rate and jank (flutter/engine#50033) 2024-01-25 [email protected] Roll Skia from 29b545e4356b to 801bb44f2b09 (1 revision) (flutter/engine#50051) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.