Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@auto-submit
Copy link
Contributor

@auto-submit auto-submit bot commented Jan 23, 2024

Reverts #49936
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Add the Mac cache_builder target back to prod.

List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#141688

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Jan 23, 2024
@auto-submit auto-submit bot merged commit d2855da into main Jan 23, 2024
@auto-submit auto-submit bot deleted the revert_b2762f4108401edc0d12fa041515169062b0e51a branch January 23, 2024 05:39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 23, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 23, 2024
…142033)

flutter/engine@37f68f6...d2855da

2024-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add Mac cache_builder back into Prod" (flutter/engine#49961)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Engine tree closing sporadically on Mac builder_cache build

2 participants