This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Fix resize crash #49935
Merged
[Windows] Fix resize crash #49935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
cbracken
reviewed
Jan 22, 2024
| // Called by |FlutterWindow| on the platform thread. | ||
| // | ||
| // Returns true if the delegate completed the window resize synchronously. | ||
| // The return value should only be used for unit testing. |
Member
There was a problem hiding this comment.
Not that I can think of a great use for this but any reason we shouldn't use it for anything other than unit tests? If so, consider documenting why that's a bad idea if it can be stated succinctly.
Member
Author
There was a problem hiding this comment.
I added this comment in case someone wonders why we discard the return value in the implementation. The implementation could use this if needed. I'll tweak the comment to make this clearer.
Member
Author
There was a problem hiding this comment.
Updated the comment!
loic-sharma
added
the
autosubmit
yaakovschectman
approved these changes
Jan 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 22, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 22, 2024
…141993) flutter/engine@b2762f4...b069d7f 2024-01-22 [email protected] Roll Skia from cd6b0ff3596e to bbb0d6feaf1c (1 revision) (flutter/engine#49943) 2024-01-22 [email protected] [Impeller] fixed CanRenderClippedRuntimeEffects for vulkan (flutter/engine#49912) 2024-01-22 [email protected] [Windows] Fix resize crash (flutter/engine#49935) 2024-01-22 [email protected] Roll Skia from be066a6524ab to cd6b0ff3596e (3 revisions) (flutter/engine#49939) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#49872 introduced a crash in debug mode if the platform thread starts a window resize in between
OnFrameGeneratedandOnFramePresented.Fixes flutter/flutter#141855.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.