This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] fixed nested save layer mipmap counts #49778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
This should fix the problem for backdrop filters, but we also need to incorporate paint filters that'll be applied to the layer #49607 (comment).
This is kind of annoying to do in EntityPass since that's part of the paint state, so I'd just recommend going for the Aiks approach.
| int32_t result = 1; | ||
| for (auto& element : elements_) { | ||
| if (auto subpass = std::get_if<std::unique_ptr<EntityPass>>(&element)) { | ||
| result = std::max(result, subpass->get()->GetRequiredMipCount()); |
There was a problem hiding this comment.
If we're gonna keep GetRequiredMipCount around, we should just rename it to GetBackdropFilterMipCount since that's what it currently is.
gaaclarke
added
the
autosubmit
|
auto label is removed for flutter/engine/49778, due to - The status or check suite Linux linux_fuchsia has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
gaaclarke
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 13, 2024
…141498) flutter/engine@b06478b...a0ac66e 2024-01-13 [email protected] [Impeller] fixed nested save layer mipmap counts (flutter/engine#49778) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
This resolves Jonah's feedback on #49607 and Brandons feedback on #49607 and #49778. This avoids the need to do a lookahead by storing the proper mip count value while building the drawing on the canvas. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #49607 (comment)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.