This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Final nail in FlutterViewEmbedder's coffin #49769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
reviewed
Jan 22, 2024
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
Thanks for the cleanup @mdebbar!
I think my only "somewhat blocking" comment would be to not make the resources field a first-class citizen of the view if it's only needed by the HTML Renderer, and keep those resources as an implementation detail of the HTML renderer.
Everything else is mostly LGTM and "woah, nice!" type of comments :P
lib/web_ui/lib/src/engine/view_embedder/embedding_strategy/embedding_strategy.dart
Show resolved
Hide resolved
lib/web_ui/lib/src/engine/view_embedder/global_html_attributes.dart
Outdated
Show resolved
Hide resolved
ditman
approved these changes
Jan 31, 2024
Member
There was a problem hiding this comment.
LGTM!
(Odd test failures, though? Did we break some pointer binding initialization?)
00:10 +237 ~2 -1: pointer_binding_test.dart: ClickDebouncer Dedupes click if pointer down/up flushed recently [E]
Expected: [
PointerChange:PointerChange.add,
PointerChange:PointerChange.down,
PointerChange:PointerChange.up
]
Actual: []
Which: at location [0] is [] which shorter than expected
Queued up events should be flushed to the framework because the time expired before the click event arrived.
Contributor
Author
|
@ditman I couldn't repro that failure locally. Rebased the PR and everything seems to be passing.. |
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 31, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 31, 2024
…142628) flutter/engine@9ccd81d...20e5361 2024-01-31 [email protected] Roll Dart SDK from fbf1d8ebceb4 to 1f136c7b962d (1 revision) (flutter/engine#50203) 2024-01-31 [email protected] Log FlutterJSONMessageCodec decode errors before asserting (flutter/engine#50163) 2024-01-31 [email protected] [web] Final nail in FlutterViewEmbedder's coffin (flutter/engine#49769) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Merged
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResourceManagerout ofFlutterViewEmbedder.GlobalHtmlAttributesout ofFlutterViewEmbedder.FlutterViewEmbedder.reset().flutterViewEmbedder.ensureFlutterViewEmbedderInitialized.FlutterViewEmbedder.Fixes flutter/flutter#134443