This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[canvaskit] Add dilate and erode imagefilters #48553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
reviewed
Dec 6, 2023
| radiusY, | ||
| null, | ||
| ); | ||
| _ref = UniqueRef<SkImageFilter>(this, skImageFilter, 'ImageFilter.dilate'); |
Contributor
There was a problem hiding this comment.
Who is responsible for calling _ref.dispose()? Or do we leak these and let GC handle the clean-up?
Contributor
Author
There was a problem hiding this comment.
We let GC handle it. Like ui.Paint, ui.ImageFilter can be created by the user and doesn't have a dispose method. There are no places in the engine where we create a temporary ImageFilter to make use of explicit disposal.
| radiusY, | ||
| null, | ||
| ); | ||
| _ref = UniqueRef<SkImageFilter>(this, skImageFilter, 'ImageFilter.erode'); |
Contributor
There was a problem hiding this comment.
Same question about disposal here.
Contributor
Author
|
Thanks! PTAL |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 23, 2024
…148919) flutter/engine@8b094fb...b8b8245 2024-05-22 [email protected] Roll Skia from 380ae98608de to 0ee149894a8d (5 revisions) (flutter/engine#52989) 2024-05-22 [email protected] Roll Skia from 396c66076ab1 to 380ae98608de (4 revisions) (flutter/engine#52983) 2024-05-22 [email protected] Reduce rebuild times when invoking 'et run' (flutter/engine#52883) 2024-05-22 [email protected] [canvaskit] Add dilate and erode imagefilters (flutter/engine#48553) 2024-05-22 [email protected] Roll Skia from 93ed643df6d1 to 396c66076ab1 (3 revisions) (flutter/engine#52981) 2024-05-22 [email protected] Fix another instance of platform view breakage on Android 14 (flutter/engine#52980) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…lutter#148919) flutter/engine@8b094fb...b8b8245 2024-05-22 [email protected] Roll Skia from 380ae98608de to 0ee149894a8d (5 revisions) (flutter/engine#52989) 2024-05-22 [email protected] Roll Skia from 396c66076ab1 to 380ae98608de (4 revisions) (flutter/engine#52983) 2024-05-22 [email protected] Reduce rebuild times when invoking 'et run' (flutter/engine#52883) 2024-05-22 [email protected] [canvaskit] Add dilate and erode imagefilters (flutter/engine#48553) 2024-05-22 [email protected] Roll Skia from 93ed643df6d1 to 396c66076ab1 (3 revisions) (flutter/engine#52981) 2024-05-22 [email protected] Fix another instance of platform view breakage on Android 14 (flutter/engine#52980) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
dilateanderodeImageFilters.Fixes flutter/flutter#101085
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.