Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Renable macOS 13 tests #48418

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Renable macOS 13 tests #48418

merged 3 commits into from
Dec 1, 2023

Conversation

@vashworth
Copy link
Contributor

A workaround was added for flutter/flutter#138238, so let's re-enable macOS 13 tests

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@vashworth vashworth mentioned this pull request Nov 27, 2023
Closed
1 task
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan-g
Copy link
Contributor

test-exempt: is a test

@jonahwilliams
Copy link
Contributor

@vashworth @jmagman does this need a reviewer?

@vashworth
Copy link
Contributor Author

@vashworth @jmagman does this need a reviewer?

Oops sorry, I'm not ready for this to be added yet. I'll mark it as draft

@vashworth vashworth marked this pull request as draft November 30, 2023 21:13
@vashworth vashworth marked this pull request as ready for review December 1, 2023 17:35
@vashworth vashworth requested a review from keyonghan December 1, 2023 17:35
keyonghan
keyonghan approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 1, 2023
@auto-submit auto-submit bot merged commit 00316e4 into flutter:main Dec 1, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 1, 2023
@engine-flutter-autoroll
00316e4b7 Renable macOS 13 tests (flutter/engine#48418)
232b7ce
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 1, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 95995c48d591 to 00316e4b7680 (1 revision) (#…
23b74b5 
…139389)

flutter/engine@95995c4...00316e4

2023-12-01 [email protected] Renable macOS 13 tests (flutter/engine#48418)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers pushed a commit to caseycrogers/flutter that referenced this pull request Dec 29, 2023
@engine-flutter-autoroll @caseycrogers
Roll Flutter Engine from 95995c48d591 to 00316e4b7680 (1 revision) (f…
a94ec7e 
…lutter#139389)

flutter/engine@95995c4...00316e4

2023-12-01 [email protected] Renable macOS 13 tests (flutter/engine#48418)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jmagman jmagman Awaiting requested review from jmagman

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vashworth @stuartmorgan-g @jonahwilliams @keyonghan