Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Make lib/ui/painting/... compatible with .clang_tidy. #47999

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Make lib/ui/painting/... compatible with .clang_tidy. #47999

merged 4 commits into from
Nov 16, 2023

Conversation

matanlurey
Copy link
Contributor

Work towards flutter/flutter#134969.

All changes were made automatically (i.e. with --fix).

@matanlurey matanlurey requested a review from dnfield November 13, 2023 23:11
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@matanlurey matanlurey added the test: all See https://github.com/flutter/engine/blob/main/docs/ci/Engine-pre-submits-and-post-submits.md label Nov 15, 2023
dnfield
dnfield approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This will be tested when we enable the lint, but should still get a test exemption.

@matanlurey
Copy link
Contributor Author

Ack. I've asked Stuart and am waiting patiently :)

@stuartmorgan-g
Copy link
Contributor

test-exempt: helps unblock turning on a check that will automatically enforce the change

@matanlurey matanlurey merged commit 22baa83 into flutter:main Nov 16, 2023
@matanlurey matanlurey deleted the engine-tidy-lib-ui-painting branch November 16, 2023 16:40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 16, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 16, 2023
@engine-flutter-autoroll
22baa83db Make lib/ui/painting/... compatible with .clang_tidy. (f…
dc4dca2 
…lutter/engine#47999)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 16, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 0c57a50810e8 to 22baa83db63b (4 revisions) (#…
d8c98c1 
…138560)

flutter/engine@0c57a50...22baa83

2023-11-16 [email protected] Make `lib/ui/painting/...` compatible with `.clang_tidy`. (flutter/engine#47999)
2023-11-16 [email protected] Re-land "Make `lib/ui/{text|window}/...` compatible with `.ci.yaml`" (flutter/engine#48097)
2023-11-16 [email protected] Roll Skia from bf1d6d84db73 to b9ead4140f84 (1 revision) (flutter/engine#48124)
2023-11-16 [email protected] Roll Skia from 2fe70dd9cbf8 to bf1d6d84db73 (1 revision) (flutter/engine#48122)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@jonahwilliams
Copy link
Contributor

This change might have slightly improved hot reload performance: https://flutter-flutter-perf.skia.org/e/?keys=X36d378e38a849bab05770ed6f82542cc&selected=commit%3D38007%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DMoto_G__4_%252Cdevice_version%253Dnone%252Chost_type%253Dmac%252Csub_result%253DhotReloadMillisecondsToFrame%252Ctest%253Dhot_mode_dev_cycle__benchmark%252C&xbaroffset=38007

@matanlurey
Copy link
Contributor Author

This change might have slightly improved hot reload performance: https://flutter-flutter-perf.skia.org/e/?keys=X36d378e38a849bab05770ed6f82542cc&selected=commit%3D38007%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DMoto_G__4_%252Cdevice_version%253Dnone%252Chost_type%253Dmac%252Csub_result%253DhotReloadMillisecondsToFrame%252Ctest%253Dhot_mode_dev_cycle__benchmark%252C&xbaroffset=38007

Neat, thanks for sharing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
test: all See https://github.com/flutter/engine/blob/main/docs/ci/Engine-pre-submits-and-post-submits.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matanlurey @stuartmorgan-g @jonahwilliams @dnfield