Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

auto-submit[bot]
Copy link
Contributor

@auto-submit auto-submit bot commented Nov 8, 2023

Reverts #47609
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
This should not land until flutter/buildroot#790 (re)lands, and I swap the buildroot url back to the latest commit. ~Reland of PR to update buildroot at flutter/buildroot#792. ~ <- landed, and changed the buildroot commit to the latest in DEPS

Upgrades to android api 34

Also:

  1. Upgrades to java 17 in DEPS/ci, because the linter now requires it.
  2. Stops running some roboelectric tests on android apis 16-18, because Roboelectric indicated those versions were unsupported and we don't support them either.
  3. Applies the four trivial new suggestions from the newer linter.
  4. Updates the baseline lint to include the new non-trivial lint (fixed in a different PR).
  5. Changes some instances where we were hardcoding android apis as numbers (e.g. `sdk = 16') to use version codes (see the comment below).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Nov 8, 2023
@auto-submit auto-submit bot merged commit 233bd62 into main Nov 8, 2023
@auto-submit auto-submit bot deleted the revert_aec3b0f549b9f6ae63494dd431bed85922d5d3e8 branch November 8, 2023 22:57
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 9, 2023
…138116)

flutter/engine@b3af5d6...233bd62

2023-11-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Upgrade Android SDK to 34 "UpsideDownCake"" (flutter/engine#47834)
2023-11-08 [email protected] Roll Skia from e585bb68893b to 1241a903cd33 (2 revisions) (flutter/engine#47830)
2023-11-08 [email protected] Upgrade Android SDK to 34 "UpsideDownCake" (flutter/engine#47609)
2023-11-08 [email protected] [macOS] Allocate textures as unique_ptr earlier (flutter/engine#47786)
2023-11-08 [email protected] Reland "[Impeller] add support for Skia concept of RRect::isSimple needed for DL dispatching" (flutter/engine#47824)
2023-11-08 [email protected] Roll Skia from e2b8ebe16203 to e585bb68893b (7 revisions) (flutter/engine#47826)
2023-11-08 [email protected] [Impeller] Add support for specialization constants (III). (flutter/engine#47765)
2023-11-08 [email protected] [Impeller] Documented the 2 step in the gaussian blur. (flutter/engine#47822)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform-android revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants