This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Bump minSdk to 19 for Android tests #47686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buildroot has switched to use 33 as default target sdk version. Signed-off-by: utzcoz <[email protected]>
The next Robolectric version, 4.11.x, removed the support for SDKs < 19 by following AndroidX strategy. Signed-off-by: utzcoz <[email protected]>
Signed-off-by: utzcoz <[email protected]>
Signed-off-by: utzcoz <[email protected]>
gmackall
approved these changes
Nov 9, 2023
shell/platform/android/test/io/flutter/plugin/localization/LocalizationPluginTest.java
Outdated
Show resolved
Hide resolved
|
Hi @gmackall , please help review again. I didn't find the real reason of "Linux linux_unopt" failed. From my understanding, this job is not related to this PR. |
|
Failure looks like it was infra related, re-running it and re-reviewing now! |
gmackall
approved these changes
Nov 10, 2023
gmackall
added
the
autosubmit
|
auto label is removed for flutter/engine/47686, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.
|
auto-submit
bot
removed
the
autosubmit
gmackall
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2023
zanderso
added
the
revert
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2023
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
This reverts commit 36f6205.
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Nov 10, 2023
Reverts #47686 Initiated by: zanderso This change reverts the following previous change: Original Description: The latest Robolectric version, 4.11.x, removed the support for SDKs < 19 by following AndroidX strategy. Also following flutter/buildroot#750, and removing obsolete SDK checking in code to pass android_lint checking after bumping minSdk to 19 for testing target. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 11, 2023
…138266) flutter/engine@9d8a112...00db306 2023-11-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Bump minSdk to 19 for Android tests" (flutter/engine#47935) 2023-11-10 [email protected] Roll Dart SDK from 91c4a92a64ea to 370145bbbd4f (1 revision) (flutter/engine#47930) 2023-11-10 [email protected] Roll Skia from 2c43bf002b7f to 96ce4d6f433d (3 revisions) (flutter/engine#47931) 2023-11-10 [email protected] [Impeller] implement Canvas::DrawLine to tesselate lines directly (flutter/engine#47846) 2023-11-10 [email protected] Roll Skia from d06840545bff to 2c43bf002b7f (1 revision) (flutter/engine#47928) 2023-11-10 [email protected] Bump minSdk to 19 for Android tests (flutter/engine#47686) 2023-11-10 [email protected] [Impeller] Reduce allocations for polyline generation (flutter/engine#47837) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Robolectric version, 4.11.x, removed the support for SDKs < 19 by following AndroidX strategy. Also following flutter/buildroot#750, and removing obsolete SDK checking in code to pass android_lint checking after bumping minSdk to 19 for testing target.
Pre-launch Checklist
///).