Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
2 changes: 1 addition & 1 deletion BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ group("unittests") {
]
}

if (!is_win && !is_fuchsia) {
if (!is_fuchsia) {
public_deps += [
"//flutter/shell/platform/android/external_view_embedder:android_external_view_embedder_unittests",
"//flutter/shell/platform/android/jni:jni_unittests",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ void AndroidExternalViewEmbedder::SubmitFlutterView(
// This is done by querying the r-tree that holds the records for the
// picture recorder corresponding to the flow layers added after a platform
// view layer.
for (ssize_t j = i; j >= 0; j--) {
for (ptrdiff_t /* portable, ssize_t is not */ j = i; j >= 0; j--) {
int64_t current_view_id = composition_order_[j];
SkRect current_view_rect = GetViewRect(current_view_id);
// The rect above the `current_view_rect`
Expand Down
12 changes: 7 additions & 5 deletions testing/run_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,7 @@ def make_test(name, flags=None, extra_env=None):
return (name, flags, extra_env)

unittests = [
make_test('android_external_view_embedder_unittests'),
make_test('client_wrapper_glfw_unittests'),
make_test('client_wrapper_unittests'),
make_test('common_cpp_core_unittests'),
Expand All @@ -383,22 +384,23 @@ def make_test(name, flags=None, extra_env=None):
make_test('embedder_a11y_unittests'),
make_test('embedder_proctable_unittests'),
make_test('embedder_unittests'),
make_test('fml_unittests'),
make_test('fml_arc_unittests'),
make_test('fml_unittests'),
make_test('jni_unittests'),
make_test('no_dart_plugin_registrant_unittests'),
make_test('platform_view_android_delegate_unittests'),
make_test('runtime_unittests'),
make_test('testing_unittests'),
make_test('tonic_unittests'),
# The image release unit test can take a while on slow machines.
make_test('ui_unittests', flags=repeat_flags + ['--timeout=90']),
]

# Print if the machine is detected as "is_windows()"
print('is_windows() = %s, on sys_paltorm = %s' % (is_windows(), sys_platform))

if not is_windows():
unittests += [
# https://github.com/google/googletest/issues/2490
make_test('android_external_view_embedder_unittests'),
make_test('jni_unittests'),
make_test('platform_view_android_delegate_unittests'),
# https://github.com/flutter/flutter/issues/36295
make_test('shell_unittests'),
]
Expand Down