This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Move all remaining Rect construction to named factories #47582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flar
force-pushed
the
remove-impeller-Rect-constructors
branch
from
44ce0c9 to
8a4ab03
Compare
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/47582, due to - The status or check suite Linux Fuchsia FEMU has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
flar
force-pushed
the
remove-impeller-Rect-constructors
branch
from
8a4ab03 to
161051b
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 2, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 2, 2023
…137744) flutter/engine@d92ccb9...be62921 2023-11-02 [email protected] [Impeller] Move all remaining Rect construction to named factories (flutter/engine#47582) 2023-11-02 [email protected] Roll Skia from 945284d57785 to 65b5bcd6c365 (12 revisions) (flutter/engine#47581) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The named factories provide better readability and do not imply an internal storage format (which will be changing soon).