This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions)" #47380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Oct 27, 2023
auto-submit
bot
deleted the
revert_bc15dffd13135d156086759d71f4afde2e4004af
branch
Member
|
The deprecation of unmodifiable typed data broke the customer_testing shard. @whesse wrote in chat: There is also a failure in the plugins with this change. It is found the by monorepo build, and could be found ahead of time by running the monorepo tryjobs on the SDK CL: Got dependencies! info - lib/src/types/picked_file/html.dart:30:38 - 'UnmodifiableUint8ListView' is deprecated and shouldn't be used. Use Uint8List.asUnmodifiableView() instead. Try replacing the use of the deprecated member with the replacement. - deprecated_member_use 1 issue found. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 27, 2023
…ddb7 (9 revisions)" (flutter/engine#47380)
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 27, 2023
…sions) (#137422) Manual roll requested by [email protected] flutter/engine@bedc49e...71e1a04 2023-10-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions)" (flutter/engine#47380) 2023-10-27 [email protected] Roll Skia from 0122c0e18d26 to fe9959acc5e0 (1 revision) (flutter/engine#47379) 2023-10-27 [email protected] Roll Fuchsia Mac SDK from 1ngqKBnmTtmFM6aBD... to fw9lcUvz8S07_zaAj... (flutter/engine#47377) 2023-10-27 [email protected] Roll Fuchsia Linux SDK from 37VxdxlPfdkek7mwC... to gPQSfYJVLOgXjxQce... (flutter/engine#47375) 2023-10-27 [email protected] Roll Skia from 22f5419438c4 to 0122c0e18d26 (1 revision) (flutter/engine#47373) 2023-10-27 [email protected] Roll Skia from 5262cbff56b1 to 22f5419438c4 (1 revision) (flutter/engine#47372) 2023-10-27 [email protected] Roll Skia from fe61b3467547 to 5262cbff56b1 (1 revision) (flutter/engine#47371) 2023-10-27 [email protected] Roll Skia from fbdd7d97b26e to fe61b3467547 (1 revision) (flutter/engine#47370) 2023-10-27 [email protected] Roll Skia from 2246f3473053 to fbdd7d97b26e (2 revisions) (flutter/engine#47369) 2023-10-27 [email protected] Roll Skia from ec4c6b3a6690 to 2246f3473053 (1 revision) (flutter/engine#47366) 2023-10-27 [email protected] [Impeller] Add FilterContents::GetSourceCoverage to enable filtered saveLayer clipping. (flutter/engine#47183) 2023-10-27 [email protected] Roll Skia from bc8ca57868d2 to ec4c6b3a6690 (1 revision) (flutter/engine#47365) 2023-10-27 [email protected] Don't re-initialize the default RenderSurface when returning from hybrid composition mode (flutter/engine#47358) 2023-10-27 [email protected] Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions) (flutter/engine#47357) 2023-10-26 [email protected] Roll Skia from 93a0ad4d7ca6 to bc8ca57868d2 (2 revisions) (flutter/engine#47359) 2023-10-26 [email protected] Roll Fuchsia Mac SDK from YSn00b0Trsu2vdhIq... to 1ngqKBnmTtmFM6aBD... (flutter/engine#47363) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 37VxdxlPfdke to gPQSfYJVLOgX fuchsia/sdk/core/mac-amd64 from YSn00b0Trsu2 to fw9lcUvz8S07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 27, 2023
…ddb7 (9 revisions)" (flutter/engine#47380)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 27, 2023
…137429) flutter/engine@bedc49e...a198ad4 2023-10-27 [email protected] [Impeller] Add present wait latch. (flutter/engine#47311) 2023-10-27 [email protected] Move rapidjson to flutter/third_party (flutter/engine#47354) 2023-10-27 [email protected] [Impeller] Enable GLES MSAA only if the multisampled_render_to_texture2 extension is available (flutter/engine#47364) 2023-10-27 [email protected] [Impeller] Fix leak of framebuffers used in GLES MSAA rendering (flutter/engine#47362) 2023-10-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions)" (flutter/engine#47380) 2023-10-27 [email protected] Roll Skia from 0122c0e18d26 to fe9959acc5e0 (1 revision) (flutter/engine#47379) 2023-10-27 [email protected] Roll Fuchsia Mac SDK from 1ngqKBnmTtmFM6aBD... to fw9lcUvz8S07_zaAj... (flutter/engine#47377) 2023-10-27 [email protected] Roll Fuchsia Linux SDK from 37VxdxlPfdkek7mwC... to gPQSfYJVLOgXjxQce... (flutter/engine#47375) 2023-10-27 [email protected] Roll Skia from 22f5419438c4 to 0122c0e18d26 (1 revision) (flutter/engine#47373) 2023-10-27 [email protected] Roll Skia from 5262cbff56b1 to 22f5419438c4 (1 revision) (flutter/engine#47372) 2023-10-27 [email protected] Roll Skia from fe61b3467547 to 5262cbff56b1 (1 revision) (flutter/engine#47371) 2023-10-27 [email protected] Roll Skia from fbdd7d97b26e to fe61b3467547 (1 revision) (flutter/engine#47370) 2023-10-27 [email protected] Roll Skia from 2246f3473053 to fbdd7d97b26e (2 revisions) (flutter/engine#47369) 2023-10-27 [email protected] Roll Skia from ec4c6b3a6690 to 2246f3473053 (1 revision) (flutter/engine#47366) 2023-10-27 [email protected] [Impeller] Add FilterContents::GetSourceCoverage to enable filtered saveLayer clipping. (flutter/engine#47183) 2023-10-27 [email protected] Roll Skia from bc8ca57868d2 to ec4c6b3a6690 (1 revision) (flutter/engine#47365) 2023-10-27 [email protected] Don't re-initialize the default RenderSurface when returning from hybrid composition mode (flutter/engine#47358) 2023-10-27 [email protected] Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions) (flutter/engine#47357) 2023-10-26 [email protected] Roll Skia from 93a0ad4d7ca6 to bc8ca57868d2 (2 revisions) (flutter/engine#47359) 2023-10-26 [email protected] Roll Fuchsia Mac SDK from YSn00b0Trsu2vdhIq... to 1ngqKBnmTtmFM6aBD... (flutter/engine#47363) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 37VxdxlPfdke to gPQSfYJVLOgX fuchsia/sdk/core/mac-amd64 from YSn00b0Trsu2 to fw9lcUvz8S07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #47357
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Manual roll requested by [email protected]
https://dart.googlesource.com/sdk.git/+log/360370ff93b0..18678a3eddb7
2023-10-26 [email protected] Version 3.3.0-65.0.dev
2023-10-26 [email protected] Version 3.3.0-64.0.dev
2023-10-26 [email protected] Version 3.3.0-63.0.dev
2023-10-26 [email protected] Version 3.3.0-62.0.dev
2023-10-26 [email protected] Version 3.3.0-61.0.dev
2023-10-25 [email protected] Version 3.3.0-60.0.dev
2023-10-25 [email protected] Version 3.3.0-59.0.dev
2023-10-25 [email protected] Version 3.3.0-58.0.dev
2023-10-24 [email protected] Version 3.3.0-57.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md