Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Only run web mac tests on macOS 12 #46965

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Only run web mac tests on macOS 12 #46965

merged 3 commits into from
Oct 17, 2023

Conversation

vashworth
Copy link
Contributor

@vashworth vashworth commented Oct 16, 2023 •
edited
Loading

Web Mac tests currently fail on macOS 13 (flutter/flutter#136274, flutter/flutter#136279) so we limit CI to only run on macOS 12.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@eyebrowsoffire
Copy link
Contributor

This is a generated file and should not be edited. At the top of the file:

  "_comment": "THIS IS A GENERATED FILE. Do not edit this file directly.",
  "_comment2": "See `generated_builder_json.dart` for the generator code",

We'd need to edit generated_builder_json.dart and then regenerate the builder json files with felt test --generate-builder-json

@eyebrowsoffire
Copy link
Contributor

Alternatively, maybe we just skip those tests on Safari for now?

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Oct 16, 2023
@vashworth
Copy link
Contributor Author

Alternatively, maybe we just skip those tests on Safari for now?

We sync'd on chat and decided against this for now because sometimes an entire suite will timeout (see flutter/flutter#136279, error 3)

eyebrowsoffire
eyebrowsoffire reviewed Oct 16, 2023
View reviewed changes
eyebrowsoffire
eyebrowsoffire approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 17, 2023
@auto-submit auto-submit bot merged commit 86f685c into flutter:main Oct 17, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 17, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 17, 2023
@engine-flutter-autoroll
86f685c87 Only run web mac tests on macOS 12 (flutter/engine#46965)
0592ae2
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 17, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 793fb7d85690 to 86f685c87e06 (1 revision) (#…
b0e56a3 
…136725)

flutter/engine@793fb7d...86f685c

2023-10-17 [email protected] Only run web mac tests on macOS 12 (flutter/engine#46965)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen pushed a commit that referenced this pull request Oct 23, 2023
@vashworth @harryterkelsen
Only run web mac tests on macOS 12 (#46965)
d875929 
Web Mac tests currently fail on macOS 13 (flutter/flutter#136274, flutter/flutter#136279) so we limit CI to only run on macOS 12.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vashworth @eyebrowsoffire