This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Allow pipeline variant sets to have differing defaults. #46751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bdero
changed the title
| std::unique_ptr<T>, | ||
| ContentContextOptions::Hash, | ||
| ContentContextOptions::Equal>; | ||
| using Variantss = std::unordered_map<ContentContextOptions, |
bdero
force-pushed
the
bdero/allow-differing-pipeline-defaults
branch
from
2826ab1 to
f80e851
Compare
jonahwilliams
approved these changes
Oct 11, 2023
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
Seems reasonable to me!
LGTM
bdero
force-pushed
the
bdero/allow-differing-pipeline-defaults
branch
from
f80e851 to
0346d04
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 11, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 11, 2023
…136315) flutter/engine@8086814...0d86d52 2023-10-11 [email protected] [Impeller] Allow pipeline variant sets to have differing defaults. (flutter/engine#46751) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
…46751) Track default prototype options along side pipeline variant sets, allowing differing defaults to be assigned during ContentContext construction.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track default prototype options along side pipeline variant sets, allowing differing defaults to be assigned during ContentContext construction.