This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Run the binary size treemap script from the buildroot directory #46740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Oct 10, 2023
| "--library", | ||
| "../../src/out/android_release_arm64/libflutter.so", | ||
| "--destdir", | ||
| "${FLUTTER_LOGS_DIR}", |
There was a problem hiding this comment.
Suggested change
| "${FLUTTER_LOGS_DIR}", | |
| "${FLUTTER_LOGS_DIR}" |
zanderso
approved these changes
Oct 10, 2023
zanderso
reviewed
Oct 10, 2023
ci/binary_size_treemap.sh
Outdated
|
|
||
| # Run the binary size script from the buildroot directory so that the treemap | ||
| # path navigation will start from there. | ||
| cd $ENGINE_BUILDROOT |
There was a problem hiding this comment.
Does this need to be "${ENGINE_BUILDROOT}" to guard against spaces in the path? Same question about the usages of $INPUT_PATH and other variables below.
jason-simmons
force-pushed
the
ci_treemap_src_root
branch
from
99efa9c to
208501c
Compare
This will produce a treemap where navigation starts from the buildroot and the flutter and third_party source directories are shown as siblings.
jason-simmons
force-pushed
the
ci_treemap_src_root
branch
from
208501c to
300deb8
Compare
zanderso
approved these changes
Oct 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 11, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 11, 2023
…136422) flutter/engine@8bf1460...05e26c1 2023-10-11 [email protected] Run the binary size treemap script from the buildroot directory (flutter/engine#46740) 2023-10-11 [email protected] [Impeller] flutter_tester --enable-impeller (flutter/engine#46389) 2023-10-11 [email protected] Switch to Chrome For Testing instead of Chromium (flutter/engine#46683) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
This will produce a treemap where navigation starts from the buildroot and the flutter and third_party source directories are shown as siblings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will produce a treemap where navigation starts from the buildroot and the flutter and third_party source directories are shown as siblings.