This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Disable layer tree screenshots. #46171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ahh, I can't actually turn on impeller in these tests 👿 |
chinmaygarde
changed the title
Contributor
Author
|
This is waiting on changes to allow testing. |
chinmaygarde
approved these changes
Oct 26, 2023
jonahwilliams
added
the
autosubmit
jonahwilliams
added
the
revert
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
This reverts commit 9927539.
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Oct 26, 2023
Reverts #46171 Initiated by: jonahwilliams This change reverts the following previous change: Original Description: The "rasterizer screenshot" VM service API uses the Skia software backend, even when running with impeller. At best, this leads to confusing half working screenshots that are missing images. See flutter/flutter#135052 We should disable this functionality when running with impeller. Perhaps this could be reworked to use picture toImage instead of the offscreen so that it uses the "real" backend regardless of the platform it is running on. Fixes flutter/flutter#135052
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 26, 2023
…137373) flutter/engine@ce1c1ee...9788bb9 2023-10-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Disable layer tree screenshots." (flutter/engine#47356) 2023-10-26 [email protected] [Windows] Refactor high contrast mode detection (flutter/engine#47314) 2023-10-26 [email protected] [Impeller] Disable layer tree screenshots. (flutter/engine#46171) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "rasterizer screenshot" VM service API uses the Skia software backend, even when running with impeller. At best, this leads to confusing half working screenshots that are missing images.
See flutter/flutter#135052
We should disable this functionality when running with impeller. Perhaps this could be reworked to use picture toImage instead of the offscreen so that it uses the "real" backend regardless of the platform it is running on.
Fixes flutter/flutter#135052