Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

matanlurey
Copy link
Contributor

Closes flutter/flutter#133708.

Will track why it's (a) blank and (b) times out in async presentation in flutter/flutter#134852.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 16, 2023
@auto-submit auto-submit bot merged commit 4909256 into flutter:main Sep 16, 2023
@matanlurey matanlurey deleted the impeller-vk-ci-validation branch September 16, 2023 15:34
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 16, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 16, 2023
…ions) (#134879)

Manual roll requested by [email protected]

flutter/engine@cdcbdcc...4909256

2023-09-16 [email protected] Add a single MacOS+Vulkan+SwiftShader CI test (flutter/engine#45918)
2023-09-16 [email protected] Roll Skia from 696ac041ea82 to a1f8fb54299a (1 revision) (flutter/engine#45917)
2023-09-16 [email protected] Roll Skia from 4851cd29e1dd to 696ac041ea82 (1 revision) (flutter/engine#45915)
2023-09-16 [email protected] Roll Skia from c19cc483c619 to 4851cd29e1dd (1 revision) (flutter/engine#45913)
2023-09-16 [email protected] Roll Dart SDK from e9452310189b to 029d6d73c860 (1 revision) (flutter/engine#45912)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
…ions) (flutter#134879)

Manual roll requested by [email protected]

flutter/engine@cdcbdcc...4909256

2023-09-16 [email protected] Add a single MacOS+Vulkan+SwiftShader CI test (flutter/engine#45918)
2023-09-16 [email protected] Roll Skia from 696ac041ea82 to a1f8fb54299a (1 revision) (flutter/engine#45917)
2023-09-16 [email protected] Roll Skia from 4851cd29e1dd to 696ac041ea82 (1 revision) (flutter/engine#45915)
2023-09-16 [email protected] Roll Skia from c19cc483c619 to 4851cd29e1dd (1 revision) (flutter/engine#45913)
2023-09-16 [email protected] Roll Dart SDK from e9452310189b to 029d6d73c860 (1 revision) (flutter/engine#45912)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen pushed a commit that referenced this pull request Oct 23, 2023
Closes flutter/flutter#133708.

Will track why it's (a) blank and (b) times out in async presentation in flutter/flutter#134852.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Impeller] Add playgrounds to CI
2 participants