Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[ios] Fix testDeallocated failing locally. #45663

Merged
merged 1 commit into from
Sep 12, 2023
Merged

[ios] Fix testDeallocated failing locally. #45663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shell/platform/darwin/ios/framework/Source/FlutterEngineTest.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ - (void)testInfoPlist {

- (void)testDeallocated {
__weak FlutterEngine* weakEngine = nil;
{
@autoreleasepool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to track down how the engine is getting onto the autorelease pool?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I'm not sure how to do that.

I have some concerns that the issue is another thread that has a retain on the engine
In what situation could this happen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only happening when running the test locally tho, ci never failed. So Im not sure what the difference is that caused the FlutterEngine getting onto the pool.

FlutterEngine* engine = [[FlutterEngine alloc] initWithName:@"foobar"];
weakEngine = engine;
[engine run];
Expand Down