This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts part of "fix auto-correction highlight on top left corner (Again)" #45523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please update the PR description to clearly explain the behavioral changes that are introduced by this partial revert. Am I correct in thinking we'll have the highlight rect in the right place (so not the upper-left-corner issue) but missing the last letter? |
Contributor
Author
|
@stuartmorgan updated the description. |
stuartmorgan-g
approved these changes
Sep 7, 2023
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Thanks for that context, it's great that this won't (at least for now) cause any known regressions.
LGTM
hellohuanlin
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 7, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 7, 2023
…134249) flutter/engine@2dba8ce...a828c26 2023-09-07 [email protected] Roll ANGLE from 204c07a56b64 to cdbc45a9f37e (1 revision) (flutter/engine#45551) 2023-09-07 [email protected] Roll Fuchsia Mac SDK from WbB3tmMXnuwJBAHoi... to EuBfOtm5TZIdgNaQe... (flutter/engine#45550) 2023-09-07 [email protected] Roll Skia from ee741e5e8cf3 to ce2c94883cb5 (1 revision) (flutter/engine#45552) 2023-09-07 [email protected] [Impeller] Started tracking the pool with the command buffer. (flutter/engine#45298) 2023-09-07 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.6.0 to 4.0.0 (flutter/engine#45439) 2023-09-07 [email protected] Reverts part of "fix auto-correction highlight on top left corner (Again)" (flutter/engine#45523) 2023-09-07 [email protected] Roll Skia from 59a2610cd83d to ee741e5e8cf3 (4 revisions) (flutter/engine#45548) 2023-09-07 [email protected] Roll ANGLE from 60b56591dee5 to 204c07a56b64 (7 revisions) (flutter/engine#45546) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from WbB3tmMXnuwJ to EuBfOtm5TZId If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
@hellohuanlin Has this question been corrected？Have you updated to the latest version？ |
Contributor
Author
Will submit a CP Monday or Tuesday. |
|
@hellohuanlin this is great, thank you |
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
… (Again)" (#45677) Original PR: #45523 *List which issues are fixed by this PR. You must list at least one issue.* Fixes flutter/flutter#133908 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts part of #44779. Verified this to be the regression for flutter/flutter#133908.
This pair of
textWill/DidChangecalls was added in Beta 1, in order to fix highlight region missing last character (more details here).However, that fix doesn't work anymore for Beta 7 - it turns out that in Beta 7, the system doesn't rely on the
selectionRectsto determine the highlight region anymore. Instead, the system relies onfirstRectForRangeAPI. So we fixed the system highlight infirstRectForRangein Beta 7.So even after reverting this change, the system highlight still works correctly in Beta 7. I was initially leaning towards keeping these calls even after Beta 7, because without it, the
selectionRectsare still out of sync with iOS text input system. (more details here).However, I was able to verify that it is indeed
textWill/DidChangethat introduced the regression for IME inputs (It's unclear why they are related, so need further investigation).In summary, after this revert, system highlights are still in the right place, and with the right length.
List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#133908
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.