This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add a build_bucket_golden_scraper tool. #45243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Aug 29, 2023
|
|
||
| // Read the file as a string. | ||
| final String contents = await file.readAsString(); | ||
|
|
There was a problem hiding this comment.
Can the file and temp directory be cleaned up after this point? I guess if you read the contents in _downloadFile() you can do all the cleanup there and make sure the temp dir gets cleaned up if the http client throws an exception.
There was a problem hiding this comment.
I can do you one better, why am I creating a temp file at all? :P
matanlurey
added
the
autosubmit
|
auto label is removed for flutter/engine/45243, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
Unblocks #45243, which adds the function: ```py def `gather_build_bucket_golden_scraper_tests`(): ```
matanlurey
added
the
autosubmit
|
Gentle ping @zanderso. Not urgent to merge, but trying to avoid this getting stale since I want to start using |
zanderso
approved these changes
Aug 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 31, 2023
jonahwilliams
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 31, 2023
…133724) flutter/engine@73e8636...3b75e3d 2023-08-31 [email protected] [Impeller] Reland DlAiksCanvas (flutter/engine#45232) 2023-08-31 [email protected] Add a build_bucket_golden_scraper tool. (flutter/engine#45243) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed offline, this is best deleted when Skia-gold is used for all of our engine tests.
However, this will be useful for unblocking some PRs until then :)
See README.md for details!