This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Supply a text backend to the AiksContext at runtime. #44884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riding the text backend in the Aiks playground/goldens
bdero
force-pushed
the
bdero/runtime-text-context
branch
from
2c711eb to
e2b4863
Compare
bdero
changed the title
bdero
changed the title
impeller/aiks/aiks_playground.cc
Outdated
| bool AiksPlayground::OpenPlaygroundHere(const Picture& picture) { | ||
| bool AiksPlayground::OpenPlaygroundHere( | ||
| const Picture& picture, | ||
| std::unique_ptr<TextRenderContext> text_render_context_override) { |
Member
There was a problem hiding this comment.
Instead of the context being provided as as override to each playground open call, I'd prefer the fixture itself take and store the context. Does it need to be unique ptr? If not, it could just store it as a shared ptr.
Avoid having to patch each call-site to open the playground and looks more extensible.
Member
Author
There was a problem hiding this comment.
By the "fixture" storing the context, do you mean having something like AiksPlayground::SetTextRenderContext()?
chinmaygarde
approved these changes
Aug 21, 2023
bdero
force-pushed
the
bdero/runtime-text-context
branch
from
63e82f1 to
c2685a2
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 22, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 22, 2023
…133026) flutter/engine@454e0e3...e183e8a 2023-08-22 [email protected] Roll Skia from 9ecdc9265aaa to 14e7b3b2d660 (1 revision) (flutter/engine#44942) 2023-08-22 [email protected] [Impeller] Supply a text backend to the AiksContext at runtime. (flutter/engine#44884) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…ter#44884) Resolves flutter/flutter#130947. - Allow for setting the text renderer (`TextRenderContext`) when the `AiksContext` is built. Previously, the text renderer was selected at build time through linking a `TextRenderContext::Create` symbol. - Support using Impeller without a text backend. Throw a clear error when trying to render text if no text backend is present. - Don't track the Impeller context in `TextRenderContext`. Just let the renderer supply its context when generating atlases. - Allow for overriding the `TextRenderContext` for individual Aiks playground tests/goldens.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#130947.
TextRenderContext) when theAiksContextis built. Previously, the text renderer was selected at build time through linking aTextRenderContext::Createsymbol.TextRenderContext. Just let the renderer supply its context when generating atlases.TextRenderContextfor individual Aiks playground tests/goldens.