This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Allow optional codepoints to be expressed to the font subset generator. #44864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: is tested bonus points for teaching the bot about this form of testing |
jason-simmons
approved these changes
Aug 18, 2023
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 19, 2023
…132876) flutter/engine@654d3a2...f4bffdc 2023-08-18 [email protected] Allow optional codepoints to be expressed to the font subset generator. (flutter/engine#44864) 2023-08-18 [email protected] Roll Skia from 2ddec49abd5c to e9cf3f1740eb (3 revisions) (flutter/engine#44862) 2023-08-18 [email protected] Roll Skia from 2dd1ed0baa7d to 2ddec49abd5c (2 revisions) (flutter/engine#44860) 2023-08-18 [email protected] Roll Skia from cf37d99d844d to 2dd1ed0baa7d (1 revision) (flutter/engine#44859) 2023-08-18 [email protected] Roll Dart SDK from 8109103e041b to a4908f67b63e (2 revisions) (flutter/engine#44858) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…r. (flutter#44864) This is the engine side change to fix flutter/flutter#132711. There will be a subsequent framework change to express the space character as an "optional" character.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the engine side change to fix flutter/flutter#132711. There will be a subsequent framework change to express the space character as an "optional" character.