This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Move remaining web-only APIs to dart:ui_web
#44516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyebrowsoffire
approved these changes
Aug 22, 2023
| } | ||
| } | ||
|
|
||
| /// Overrides the value of [ui.FlutterView.devicePixelRatio] in tests. |
Contributor
There was a problem hiding this comment.
Just to clarify here... the framework uses this for testing? If not, and this is only used in the engine, I think we can just remove the API completely. If it is used in the framework... blech. I wish we could just actually control this with the test harness rather than having a special magic debug API.
That being said, if the framework is using this, I'm fine with just moving forward this way.
(Ditto for debugPhysicalSizeOverride above)
Contributor
There was a problem hiding this comment.
I went and looked it up and answered my own question... yes the framework uses it for testing in its test bootstrap. 😞
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 22, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 22, 2023
…133078) flutter/engine@28b8bd5...b190f90 2023-08-22 [email protected] Roll Skia from 50814d9ca5bb to 9f4b81aac175 (1 revision) (flutter/engine#44969) 2023-08-22 [email protected] [web] Move remaining web-only APIs to `dart:ui_web` (flutter/engine#44516) 2023-08-22 [email protected] Revert "Split DisplayListBuilder into DlCanvas optimizer and DlOp recorder classes" (flutter/engine#44968) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 29, 2023
This is the last batch of web-only API migration. Depends on flutter/engine#44516 Fixes #52899 Fixes #126831
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
- Warn on `webOnlyInitializePlatform` and replace all usages with `ui_web.bootstrapEngine`. - Remove unused `webOnlyPaintedBy` parameter. - `webOnlyDebugPhysicalSizeOverride` => `ui_web.debugPhysicalSizeOverride`. - `webOnlyInstantiateImageCodecFromUrl` => `ui_web.createImageCodecFromUrl`. - `WebOnlyImageCodecChunkCallback` => `ui_web.ImageCodecChunkCallback`. - `_webOnlyDidWarnAboutPerformanceOverlay` => `_didWarnAboutPerformanceOverlay`. - Remove unnecessary usage of `futurize`. Part of flutter/flutter#126831
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webOnlyInitializePlatformand replace all usages withui_web.bootstrapEngine.webOnlyPaintedByparameter.ui.window.debugOverrideDevicePixelRatio=>ui_web.debugOverrideDevicePixelRatioui.window.webOnlyDebugPhysicalSizeOverride=>ui.window.debugPhysicalSizeOverride(an extension method indart:ui_web.webOnlyInstantiateImageCodecFromUrl=>ui_web.createImageCodecFromUrl.WebOnlyImageCodecChunkCallback=>ui_web.ImageCodecChunkCallback._webOnlyDidWarnAboutPerformanceOverlay=>_didWarnAboutPerformanceOverlay.futurize.Part of flutter/flutter#126831