This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Set the required Android API level when Vulkan validation layers are automatically enabled for android_debug_unopt_arm64 builds #44116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…automatically enabled for android_debug_unopt_arm64 builds
Contributor
|
Thanks! Do you mind editing the PR description and add 1-2 sentences on what problem this solves for posterity? |
matanlurey
approved these changes
Jul 28, 2023
Member
Author
done |
Contributor
|
That makes sense, thanks for fixing this! |
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 28, 2023
…ayers are automatically enabled for android_debug_unopt_arm64 builds (flutter/engine#44116)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 28, 2023
…131519) flutter/engine@da3721a...b4bf592 2023-07-28 [email protected] Set the required Android API level when Vulkan validation layers are automatically enabled for android_debug_unopt_arm64 builds (flutter/engine#44116) 2023-07-28 [email protected] Roll Dart SDK from e9bdbe308478 to 69c96c505f05 (1 revision) (flutter/engine#44118) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…lutter#131519) flutter/engine@da3721a...b4bf592 2023-07-28 [email protected] Set the required Android API level when Vulkan validation layers are automatically enabled for android_debug_unopt_arm64 builds (flutter/engine#44116) 2023-07-28 [email protected] Roll Dart SDK from e9bdbe308478 to 69c96c505f05 (1 revision) (flutter/engine#44118) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
…lutter#131519) flutter/engine@da3721a...b4bf592 2023-07-28 [email protected] Set the required Android API level when Vulkan validation layers are automatically enabled for android_debug_unopt_arm64 builds (flutter/engine#44116) 2023-07-28 [email protected] Roll Dart SDK from e9bdbe308478 to 69c96c505f05 (1 revision) (flutter/engine#44118) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…automatically enabled for android_debug_unopt_arm64 builds (flutter#44116) The Vulkan validation layer headers will not build if the Android API level is 23 or lower. Currently the engine buildroot's default Android API level is 23. The API level must be overridden for any configuration where Vulkan validation is enabled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vulkan validation layer headers will not build if the Android API level is 23 or lower.
Currently the engine buildroot's default Android API level is 23. The API level must be overridden for any configuration where Vulkan validation is enabled.