This repository was archived by the owner on Feb 25, 2025. It is now read-only.
header file cleanup focusing on removing unnecessary SkPicture includes #43589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two unit tests were discovered to be completely identical to their DisplayList counterparts having been edited in a previous de-skia-fication pass. Both are deleted as redundant. |
flar
commented
Jul 12, 2023
| int sk_op_count() { return sk_op_count_; } | ||
| // byte count for the ops with DisplayList overhead as translated | ||
| // through an SkCanvas interface, comparable to |DisplayList.byte_count(). | ||
| size_t sk_byte_count() { return sizeof(DisplayList) + sk_byte_count_; } |
There was a problem hiding this comment.
These 2 fields can be deleted now, but it would cascade into a huge edit of the long list of test cases that are expressed using this structure, so I'm leaving that for a future pass.
chinmaygarde
approved these changes
Jul 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 12, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 12, 2023
…130398) flutter/engine@29c5c41...73093fd 2023-07-12 [email protected] header file cleanup focusing on removing unnecessary SkPicture includes (flutter/engine#43589) 2023-07-12 [email protected] [Impeller] Document ColorSourceContents (flutter/engine#43590) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 13, 2023
…lutter#130398) flutter/engine@29c5c41...73093fd 2023-07-12 [email protected] header file cleanup focusing on removing unnecessary SkPicture includes (flutter/engine#43589) 2023-07-12 [email protected] [Impeller] Document ColorSourceContents (flutter/engine#43590) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
…es (flutter#43589) Most of the #include directives for SkPicture are removed except where they are still functional. Many comments rewritten to no longer be SkPicture-centric. - DL unit tests still use it for consistency testing - rasterizer/engine still use it for screen shot support - Fuchsia still uses it extensively
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the #include directives for SkPicture are removed except where they are still functional. Many comments rewritten to no longer be SkPicture-centric.