Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

bdero
Copy link
Member

@bdero bdero commented Jun 30, 2023

Reverts #42584. (Thanks to @jonahwilliams for bisecting)

With this change, layers are getting clipped incorrectly when rendering platform views in Wondrous.

Issue: flutter/flutter#129816.

Before revert:

Before.mov

After revert:

After.mov

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think we'll need to file a cp request if this has missed the branch cut off too. We can deal with that later though

@bdero bdero merged commit fc9fc93 into main Jun 30, 2023
@bdero bdero deleted the revert-42584-DL-builder-detect-nop-3 branch June 30, 2023 11:22
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 30, 2023
…129852)

flutter/engine@54b573e...e6b8292

2023-06-30 [email protected] [Impeller] cache MSAA texture in swapchain for devices that do not support memoryless. (flutter/engine#43349)
2023-06-30 [email protected] [Impeller] Fix validation error in position color shader. (flutter/engine#43356)
2023-06-30 [email protected] Fix inverted boolean in Windows document selection changed a11y event (flutter/engine#43281)
2023-06-30 [email protected] Revert "Reland "add non-rendering operation culling to DisplayListBuilder" (#41463)" (flutter/engine#43358)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@chinmaygarde
Copy link
Member

@bdero In the videos, the first couple of seconds with the swipe down seem janky. Are those real issues on the latest build or an artifact of how the video was captured? Just a drive by comment on something unrelated :)

@jonahwilliams
Copy link
Contributor

on non-release builds the google maps plugin initialization is really slow. Doesn't happen in release mode

@bdero
Copy link
Member Author

bdero commented Jul 1, 2023

Yeah, I think this debug-only stutter in Wondrous is a known quantity and has been around for a long time.

kjlubick pushed a commit to kjlubick/engine that referenced this pull request Jul 14, 2023
…lder" (flutter#41463)" (flutter#43358)

Reverts flutter#42584. (Thanks to @jonahwilliams for bisecting)

With this change, layers are getting clipped incorrectly when rendering
platform views in Wondrous.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants