Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Added CI step for building with validation layers #42724

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Added CI step for building with validation layers #42724

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d7a27a
Added CI step for building with validation layers
gaaclarke Jun 10, 2023
c2bbe70
added cas_archive:false
gaaclarke Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions ci/builders/linux_android_debug_engine.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,27 @@
]
}
},
{
"cas_archive": false,
"drone_dimensions": [
"device_type=none",
"os=Linux"
],
"gn": [
"--android",
"--android-cpu=arm64",
"--no-lto",
"--enable-vulkan-validation-layers"
],
"name": "android_debug_arm64",
Copy link
Member Author

@gaaclarke gaaclarke Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to give this a unique name but it didn't work since that name has to match the name of the generated directory by GN.

Copy link
Contributor

@keyonghan keyonghan Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried keeping the name and the ninja config same when using the unique name?

Copy link
Member Author

@gaaclarke gaaclarke Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, i don't know if there is an easy way to recall that failure though since I rebased.

Copy link
Contributor

@keyonghan keyonghan Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the history build of https://ci.chromium.org/p/flutter/builders/try/Linux%20linux_android_debug_engine?limit=50, are you referring to https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_android_debug_engine/11608/overview? The failed build run is: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/972265/overview

But the input properties shows "config": "android_debug_arm64":

"build": {
    "archives": [],
    "drone_dimensions": [
      "device_type=none",
      "os=Linux"
    ],
    "gn": [
      "--android",
      "--android-cpu=arm64",
      "--no-lto",
      "--enable-vulkan-validation-layers"
    ],
    "name": "android_debug_arm64_validation_layers",
    "ninja": {
      "config": "android_debug_arm64",
      "targets": [
        "flutter",
        "flutter/shell/platform/android:abi_jars"
      ]
    },
    "recipe": "engine_v2/builder"
  },

Copy link
Member Author

@gaaclarke gaaclarke Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure I tried it. I just pushed that change to be sure.

Copy link
Contributor

@keyonghan keyonghan Jun 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: use a different name, say your earlier change android_debug_arm64_validation_layers, to distinguish the builds. Now it shows two same builds (https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_android_debug_engine/11686/overview):
Screenshot 2023-06-13 at 2 58 44 PM

Copy link
Member Author

@gaaclarke gaaclarke Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keyonghan I can't use a different name, right? We tried that above.

Copy link
Contributor

@godofredoc godofredoc Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with cas_archive = false is safe to use a different name.

Copy link
Contributor

@keyonghan keyonghan Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With "cas_archive": false,, I would expect the build to pass.

Copy link
Member Author

@gaaclarke gaaclarke Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, worked with that field: #42826

"ninja": {
"config": "android_debug_arm64",
"targets": [
"flutter",
"flutter/shell/platform/android:abi_jars"
]
}
},
{
"archives": [
{
Expand Down