Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] added debug info to frame debuggers like AGI #42717

Merged
merged 1 commit into from
Jun 12, 2023
Merged

[Impeller] added debug info to frame debuggers like AGI #42717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions impeller/renderer/backend/vulkan/capabilities_vk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,13 @@ CapabilitiesVK::GetRequiredInstanceExtensions() const {
}
required.push_back("VK_EXT_debug_utils");

if (!HasExtension("VK_EXT_validation_features")) {
VALIDATION_LOG << "Requested validations but could not find the "
if (HasExtension("VK_EXT_validation_features")) {
// It's valid to not have `VK_EXT_validation_features` available. That's
// the case when using AGI as a frame debugger.
FML_DLOG(INFO) << "Requested validations but could not find the "
"VK_EXT_validation_features extension.";
return std::nullopt;
required.push_back("VK_EXT_validation_features");
}
required.push_back("VK_EXT_validation_features");
}

return required;
Expand Down