This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[Impeller] Add Impeller Metal support in the embedder API (#42411)" #42532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
embedder
…utter#42411)" This reverts commit 052e226.
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine, pr: 42532, due to - The status or check suite Mac iOS clang-tidy has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
bdero
force-pushed
the
bdero/revert-impeller-embedder
branch
from
0a0c5c6 to
0708a61
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 3, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 3, 2023
…128161) flutter/engine@5429372...c838a1b 2023-06-03 [email protected] Roll Skia from daf2219fec54 to 656de7fc6994 (23 revisions) (flutter/engine#42534) 2023-06-03 [email protected] Revert "[Impeller] Add Impeller Metal support in the embedder API (#42411)" (flutter/engine#42532) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 052e226.
Expected to resolve flutter/flutter#128145