Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@sealesj
Copy link
Contributor

@sealesj sealesj commented May 23, 2023

This change allows for anyone submitting a PR which resolves a vulnerability found from the scanning action to be run on the PR to check for resolution if the label 'vulnerability patch' is applied to the PR.

List which issues are fixed by this PR. You must list at least one issue.
b/283970087

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@drewroengoogle drewroengoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sealesj
Copy link
Contributor Author

sealesj commented May 23, 2023

Confirmed with this workflow that updates to the DEPS file will be pulled in on the run of the vuln scan https://github.com/sealesj/engine/actions/runs/5060655602

@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2023
@auto-submit auto-submit bot merged commit 15d28bb into flutter:main May 23, 2023
@sealesj sealesj removed the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2023
sealesj added a commit that referenced this pull request May 23, 2023
auto-submit bot pushed a commit that referenced this pull request May 23, 2023
Reverts #42247

Reverting in order to find solution which doesn't add a skipped test onto all PRs. Only PRs which address vuln scanning need to have this test showing at all.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 23, 2023
…127428)

flutter/engine@23b0431...3535e0d

2023-05-23 [email protected] Revert "Vuln scan on 3p deps triggered by label on PR" (flutter/engine#42256)
2023-05-23 [email protected] Vuln scan on 3p deps triggered by label on PR (flutter/engine#42247)
2023-05-23 [email protected] Revert "[Impeller] use host image upload path on simulator" (flutter/engine#42212)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
…lutter#127428)

flutter/engine@23b0431...3535e0d

2023-05-23 [email protected] Revert "Vuln scan on 3p deps triggered by label on PR" (flutter/engine#42256)
2023-05-23 [email protected] Vuln scan on 3p deps triggered by label on PR (flutter/engine#42247)
2023-05-23 [email protected] Revert "[Impeller] use host image upload path on simulator" (flutter/engine#42212)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants