Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] remove final cmd buffer waitUntilScheduled on physical iOS #42160

Merged
merged 2 commits into from
May 22, 2023
Merged

[Impeller] remove final cmd buffer waitUntilScheduled on physical iOS #42160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40b9467
[Impeller] remove final cmd buffer waitUntilScheduled on physical iOS
May 19, 2023
35de243
Merge branch 'main' into remove_wait_ios
May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions impeller/renderer/backend/metal/surface_mtl.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@
}
}

#if ((FML_OS_MACOSX && !FML_OS_IOS) || FML_OS_IOS_SIMULATOR)
// If a transaction is present, `presentDrawable` will present too early. And
// so we wait on an empty command buffer to get scheduled instead, which
// forces us to also wait for all of the previous command buffers in the queue
Expand All @@ -187,6 +188,8 @@
ContextMTL::Cast(context.get())->CreateMTLCommandBuffer();
[command_buffer commit];
[command_buffer waitUntilScheduled];
#endif // ((FML_OS_MACOSX && !FML_OS_IOS) || FML_OS_IOS_SIMULATOR)

[drawable_ present];

return true;
Expand Down