-
Notifications
You must be signed in to change notification settings - Fork 6k
Support DisposalMethod::kRestorePrevious in MultiFrameCodec and fix the apng problem. #42153
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
% ../../flutter_macos_3.10.1-stable/flutter/bin/flutter doctor -v [!] Flutter (Channel stable, 3.10.1, on macOS 13.2.1 22D68 darwin-x64, locale zh-Hans-CN) |
|
Here is the problem video 3.10 exists: apng_problem.mp4Here is the problem example: |
This reverts commit ee97ded.
bdero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM w\ nit about naming.
|
after a more efficient solution apng_ok.mp4 |
bdero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
… and fix the apng problem. (flutter/engine#42153)
… and fix the apng problem. (flutter/engine#42153)
… and fix the apng problem. (flutter/engine#42153)
…128089) flutter/engine@3a453f2...02d6fbb 2023-06-01 [email protected] [Impeller] Emplace directly into host buffer (avoid VBB) for text data (flutter/engine#42484) 2023-06-01 [email protected] Ensure PlatformView engine life cycle callbacks are invoked (flutter/engine#42491) 2023-06-01 [email protected] Roll Skia from c408e8e9cc96 to 082a7d1f72f7 (8 revisions) (flutter/engine#42496) 2023-06-01 [email protected] [Windows - TextInput] Insert new line only when TextInputAction.newline (flutter/engine#42244) 2023-06-01 [email protected] Revert "Move clang tidy v2 build to prod." (flutter/engine#42495) 2023-06-01 [email protected] Add myself to AUTHORS (flutter/engine#42406) 2023-06-01 [email protected] [Impeller] Add Impeller Metal support in the embedder API (flutter/engine#42411) 2023-06-01 [email protected] Support DisposalMethod::kRestorePrevious in MultiFrameCodec and fix the apng problem. (flutter/engine#42153) 2023-06-01 [email protected] Fix crash getting spell-check suggestions (flutter/engine#42466) 2023-06-01 [email protected] Fix lint in rectangle packer (flutter/engine#42489) 2023-06-01 [email protected] Wait for GL command completion in the ExternalTextureGLRefreshedTooOften test (flutter/engine#42438) 2023-06-01 [email protected] Reland "[web] Remove the JS API for url strategy (#42134)" (flutter/engine#42486) 2023-06-01 [email protected] Roll Skia from f5bc3d12f0eb to c408e8e9cc96 (9 revisions) (flutter/engine#42487) 2023-06-01 [email protected] Clean up Skia includes around SkSurfaceCharacterization (flutter/engine#42485) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Support DisposalMethod::kRestorePrevious in MultiFrameCodec and fix the apng problem.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.