Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@toneyzeng
Copy link
Contributor

@toneyzeng toneyzeng commented May 19, 2023

Support DisposalMethod::kRestorePrevious in MultiFrameCodec and fix the apng problem.

image

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@toneyzeng
Copy link
Contributor Author

% ../../flutter_macos_3.10.1-stable/flutter/bin/flutter doctor -v

[!] Flutter (Channel stable, 3.10.1, on macOS 13.2.1 22D68 darwin-x64, locale zh-Hans-CN)
• Flutter version 3.10.1 on channel stable at /Users/zengjh/git/offical-flutter/flutter_macos_3.10.1-stable/flutter
! Warning: flutter on your path resolves to /Users/zengjh/git/hummers/hummer_2.5.1.7/src/flutter/uc/flutter_sdk/bin/flutter, which is not inside your current Flutter SDK checkout at
/Users/zengjh/git/offical-flutter/flutter_macos_3.10.1-stable/flutter. Consider adding /Users/zengjh/git/offical-flutter/flutter_macos_3.10.1-stable/flutter/bin to the front of your path.
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision d3d8effc68 (2 days ago), 2023-05-16 17:59:05 -0700
• Engine revision b4fb112
• Dart version 3.0.1
• DevTools version 2.23.1
• If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

@toneyzeng
Copy link
Contributor Author

Here is the problem video 3.10 exists:

apng_problem.mp4

Here is the problem example:

apng-demo-toneyzeng.zip

@chinmaygarde chinmaygarde requested a review from bdero May 25, 2023 20:11
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM w\ nit about naming.

@toneyzeng
Copy link
Contributor Author

after a more efficient solution

apng_ok.mp4

@toneyzeng toneyzeng requested a review from bdero May 29, 2023 02:14
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 1, 2023
@auto-submit auto-submit bot merged commit 4bee37e into flutter:main Jun 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 1, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 2, 2023
…128089)

flutter/engine@3a453f2...02d6fbb

2023-06-01 [email protected] [Impeller] Emplace directly into host buffer (avoid VBB) for text data (flutter/engine#42484)
2023-06-01 [email protected] Ensure PlatformView engine life cycle callbacks are invoked (flutter/engine#42491)
2023-06-01 [email protected] Roll Skia from c408e8e9cc96 to 082a7d1f72f7 (8 revisions) (flutter/engine#42496)
2023-06-01 [email protected] [Windows - TextInput] Insert new line only when TextInputAction.newline (flutter/engine#42244)
2023-06-01 [email protected] Revert "Move clang tidy v2 build to prod." (flutter/engine#42495)
2023-06-01 [email protected] Add myself to AUTHORS (flutter/engine#42406)
2023-06-01 [email protected] [Impeller] Add Impeller Metal support in the embedder API (flutter/engine#42411)
2023-06-01 [email protected] Support DisposalMethod::kRestorePrevious in MultiFrameCodec and fix the apng problem. (flutter/engine#42153)
2023-06-01 [email protected] Fix crash getting spell-check suggestions (flutter/engine#42466)
2023-06-01 [email protected] Fix lint in rectangle packer (flutter/engine#42489)
2023-06-01 [email protected] Wait for GL command completion in the ExternalTextureGLRefreshedTooOften test (flutter/engine#42438)
2023-06-01 [email protected] Reland "[web] Remove the JS API for url strategy (#42134)" (flutter/engine#42486)
2023-06-01 [email protected] Roll Skia from f5bc3d12f0eb to c408e8e9cc96 (9 revisions) (flutter/engine#42487)
2023-06-01 [email protected] Clean up Skia includes around SkSurfaceCharacterization (flutter/engine#42485)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants