This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Remove the JS API for url strategy #42134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 1, 2023
jonahwilliams
pushed a commit
that referenced
this pull request
Jun 1, 2023
This reverts commit c1ef0d9.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 1, 2023
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
Reverts #42134 This is blocking the engine into framework roller: See: https://cirrus-ci.com/task/5610586755563520 ``` Analyzing 3 items... error � The class 'UrlStrategy' can't be extended outside of its library because it's an interface class � dev/integration_tests/web_e2e_tests/test_driver/url_strategy_integration.dart:48:31 � invalid_use_of_type_outside_library 1 issue found. (ran in 321.8s) � � ```
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 1, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 1, 2023
…128009) flutter/engine@f9bc342...6db2f3e 2023-06-01 [email protected] Revert "[web] Remove the JS API for url strategy" (flutter/engine#42468) 2023-06-01 [email protected] Roll Dart SDK from e0caea366989 to 78d09b5874fa (4 revisions) (flutter/engine#42465) 2023-06-01 [email protected] Roll Fuchsia Linux SDK from lSKDoGVypQfTMYUZe... to htio0wC3kDb9tB1Wd... (flutter/engine#42463) 2023-05-31 [email protected] [web] Remove the JS API for url strategy (flutter/engine#42134) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from lSKDoGVypQfT to htio0wC3kDb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mdebbar
added a commit
to mdebbar/engine
that referenced
this pull request
Jun 1, 2023
This reverts commit 6db2f3e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, we can remove this JS global function for customizing the url strategy.
Why I think we don't need to go through an official deprecation process:
flutter_web_pluginswhich has been migrated already.