Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@bdero
Copy link
Member

@bdero bdero commented May 15, 2023

Made this to help debugging clear color problems and I've had it sitting around in my stage for a few days. Today, it ended up leading me to discover several other issues. For example, advanced blends are doing nothing in this case...

Screenshot 2023-05-14 at 7 14 43 PM

@bdero bdero requested review from chinmaygarde and zanderso May 15, 2023 02:31
@bdero bdero self-assigned this May 15, 2023
@bdero bdero force-pushed the bdero/drawpaint-interactive branch 3 times, most recently from 807c2ba to 8e01fb3 Compare May 15, 2023 03:21
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdero bdero force-pushed the bdero/drawpaint-interactive branch from 8e01fb3 to c1e02b5 Compare May 15, 2023 18:52
@bdero bdero merged commit 7285376 into flutter:main May 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 15, 2023
…126876)

flutter/engine@00f20fb...027ca79

2023-05-15 [email protected] Use release_build and os dimension consistently. (flutter/engine#42012)
2023-05-15 [email protected] [Impeller] Add interactive DrawPaint blend test (flutter/engine#42031)
2023-05-15 [email protected] [Impeller] Limit subpass textures and backdrop blurs to the current clip (flutter/engine#42039)
2023-05-15 [email protected] Roll Dart SDK from c302a0252785 to d2b2ac829842 (1 revision) (flutter/engine#42051)
2023-05-15 [email protected] Upload xcresults to LUCI cloud storage (flutter/engine#41647)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
…lutter#126876)

flutter/engine@00f20fb...027ca79

2023-05-15 [email protected] Use release_build and os dimension consistently. (flutter/engine#42012)
2023-05-15 [email protected] [Impeller] Add interactive DrawPaint blend test (flutter/engine#42031)
2023-05-15 [email protected] [Impeller] Limit subpass textures and backdrop blurs to the current clip (flutter/engine#42039)
2023-05-15 [email protected] Roll Dart SDK from c302a0252785 to d2b2ac829842 (1 revision) (flutter/engine#42051)
2023-05-15 [email protected] Upload xcresults to LUCI cloud storage (flutter/engine#41647)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants