Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@godofredoc
Copy link
Contributor

CP: 3b9ff41

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

The mac clang tidy build has been running successfully on staging for several days. This is also moving the ios and host legacy clang tidy builds to staging.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@godofredoc godofredoc requested a review from XilaiZhang May 13, 2023 03:58
Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images (1)

@CaseyHillers
Copy link
Contributor

@godofredoc this has merge conflicts. Can you resolve them?

@XilaiZhang
Copy link
Contributor

Umm friendly ping @godofredoc , maybe we would like to have this in the beta hotfix this week

@XilaiZhang
Copy link
Contributor

my bad, no rush on this one, this week is stable hotfix, beta is next week

@godofredoc godofredoc merged commit 6f945e8 into flutter:flutter-3.11-candidate.0 May 17, 2023
@godofredoc godofredoc deleted the cp_2_6 branch May 17, 2023 00:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants